You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2025/11/14 15:05:45 UTC

[PR] [fix] Handle TLS close_notify to avoid SslClosedEngineException: SSLEngine closed already [pulsar]

lhotari opened a new pull request, #24986:
URL: https://github.com/apache/pulsar/pull/24986

   ### Motivation
   
   Received this log entry which caused unnecessary retries and latency on a Pulsar client:
   ```
   failed to get Partitioned metadata : SSLEngine closed already org.apache.pulsar.shade.io.netty.handler.ssl.SslClosedEngineException: SSLEngine closed already
   ```
   
   There's a similar issue that was resolved in reactor-netty with this PR https://github.com/reactor/reactor-netty/pull/2518
   
   More details:
   * https://datatracker.ietf.org/doc/html/rfc8446#section-6.1
   * [SSL / TLS: Is a server always required to respond to a close notify?](https://security.stackexchange.com/questions/82028/ssl-tls-is-a-server-always-required-to-respond-to-a-close-notify)
     * Since TLS 1.3, it's not even part of the spec to have a response. In TLS 1.2, it's optional.
   
   ### Modifications
   
   - Close the channel immediately when TLS close_notify event is received
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix] Handle TLS close_notify to avoid SslClosedEngineException: SSLEngine closed already [pulsar]

Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece merged PR #24986:
URL: https://github.com/apache/pulsar/pull/24986


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [fix] Handle TLS close_notify to avoid SslClosedEngineException: SSLEngine closed already [pulsar]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24986:
URL: https://github.com/apache/pulsar/pull/24986#issuecomment-3533662590

   ## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/24986?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `83.33333%` with `2 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 74.32%. Comparing base ([`2c9fc94`](https://app.codecov.io/gh/apache/pulsar/commit/2c9fc9400a70ae2ac8bd89212b75248a7a4c9195?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`a0673ea`](https://app.codecov.io/gh/apache/pulsar/commit/a0673ead6efafdfeeb4631d0ce64c3e9b61472b8?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 2 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/pulsar/pull/24986?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...g/apache/pulsar/common/protocol/PulsarDecoder.java](https://app.codecov.io/gh/apache/pulsar/pull/24986?src=pr&el=tree&filepath=pulsar-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fcommon%2Fprotocol%2FPulsarDecoder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbW1vbi9wcm90b2NvbC9QdWxzYXJEZWNvZGVyLmphdmE=) | 83.33% | [1 Missing and 1 partial :warning: ](https://app.codecov.io/gh/apache/pulsar/pull/24986?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   [![Impacted file tree graph](https://app.codecov.io/gh/apache/pulsar/pull/24986/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)](https://app.codecov.io/gh/apache/pulsar/pull/24986?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #24986       +/-   ##
   =============================================
   + Coverage     38.63%   74.32%   +35.68%     
   - Complexity    13324    33664    +20340     
   =============================================
     Files          1863     1920       +57     
     Lines        146089   150258     +4169     
     Branches      16942    17431      +489     
   =============================================
   + Hits          56445   111672    +55227     
   + Misses        81999    29690    -52309     
   - Partials       7645     8896     +1251     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/pulsar/pull/24986/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [inttests](https://app.codecov.io/gh/apache/pulsar/pull/24986/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.55% <50.00%> (+0.25%)` | :arrow_up: |
   | [systests](https://app.codecov.io/gh/apache/pulsar/pull/24986/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `22.83% <0.00%> (+<0.01%)` | :arrow_up: |
   | [unittests](https://app.codecov.io/gh/apache/pulsar/pull/24986/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.85% <83.33%> (+38.98%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/pulsar/pull/24986?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [.../java/org/apache/pulsar/client/impl/ClientCnx.java](https://app.codecov.io/gh/apache/pulsar/pull/24986?src=pr&el=tree&filepath=pulsar-client%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fclient%2Fimpl%2FClientCnx.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL0NsaWVudENueC5qYXZh) | `68.97% <ø> (+15.66%)` | :arrow_up: |
   | [...g/apache/pulsar/common/protocol/PulsarDecoder.java](https://app.codecov.io/gh/apache/pulsar/pull/24986?src=pr&el=tree&filepath=pulsar-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fpulsar%2Fcommon%2Fprotocol%2FPulsarDecoder.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NvbW1vbi9wcm90b2NvbC9QdWxzYXJEZWNvZGVyLmphdmE=) | `65.42% <83.33%> (+7.16%)` | :arrow_up: |
   
   ... and [1422 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/24986/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
   </details>
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org