You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/04/01 22:34:04 UTC
[GitHub] [beam] robertwb opened a new pull request #11283: [BEAM-9322]
[BEAM-1833] Better naming for composite transform output tags.
robertwb opened a new pull request #11283: [BEAM-9322] [BEAM-1833] Better naming for composite transform output tags.
URL: https://github.com/apache/beam/pull/11283
This gives names like `'a', 'b.0', 'b.1'` for results like {'a': ..., 'b': (..., ...)}`.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] robertwb commented on issue #11283: [BEAM-9322] [BEAM-1833]
Better naming for composite transform output tags.
Posted by GitBox <gi...@apache.org>.
robertwb commented on issue #11283: [BEAM-9322] [BEAM-1833] Better naming for composite transform output tags.
URL: https://github.com/apache/beam/pull/11283#issuecomment-608712255
@rohdesamuel is this good to go?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] robertwb commented on a change in pull request #11283:
[BEAM-9322] [BEAM-1833] Better naming for composite transform output tags.
Posted by GitBox <gi...@apache.org>.
robertwb commented on a change in pull request #11283: [BEAM-9322] [BEAM-1833] Better naming for composite transform output tags.
URL: https://github.com/apache/beam/pull/11283#discussion_r401995268
##########
File path: sdks/python/apache_beam/pipeline.py
##########
@@ -671,7 +671,11 @@ def apply(
# If the user wants the old implementation of always generated
# PCollection output ids, then set the tag to None first, then count up
# from 1.
- tag = len(current.outputs) if None in current.outputs else None
+ base = tag
+ counter = 0
+ while tag in current.outputs:
+ counter += 1
+ tag = '%s_%d' % (base, counter)
current.add_output(result, tag)
Review comment:
I am relatively confident in this change, as it preserves the essential characteristic (that output names are unique) and defaults to the same thing for all single-output transforms. However, I have added the opt-out you had originally with a note just in case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] rohdesamuel commented on a change in pull request #11283:
[BEAM-9322] [BEAM-1833] Better naming for composite transform output tags.
Posted by GitBox <gi...@apache.org>.
rohdesamuel commented on a change in pull request #11283: [BEAM-9322] [BEAM-1833] Better naming for composite transform output tags.
URL: https://github.com/apache/beam/pull/11283#discussion_r401967131
##########
File path: sdks/python/apache_beam/pipeline.py
##########
@@ -671,7 +671,11 @@ def apply(
# If the user wants the old implementation of always generated
# PCollection output ids, then set the tag to None first, then count up
# from 1.
- tag = len(current.outputs) if None in current.outputs else None
+ base = tag
+ counter = 0
+ while tag in current.outputs:
+ counter += 1
+ tag = '%s_%d' % (base, counter)
current.add_output(result, tag)
Review comment:
Should this be under the experiment flag instead, so that we don't inadvertently break anyone?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] robertwb commented on issue #11283: [BEAM-9322] [BEAM-1833]
Better naming for composite transform output tags.
Posted by GitBox <gi...@apache.org>.
robertwb commented on issue #11283: [BEAM-9322] [BEAM-1833] Better naming for composite transform output tags.
URL: https://github.com/apache/beam/pull/11283#issuecomment-608712134
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] robertwb commented on issue #11283: [BEAM-9322] [BEAM-1833]
Better naming for composite transform output tags.
Posted by GitBox <gi...@apache.org>.
robertwb commented on issue #11283: [BEAM-9322] [BEAM-1833] Better naming for composite transform output tags.
URL: https://github.com/apache/beam/pull/11283#issuecomment-607960904
Run Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] rohdesamuel commented on issue #11283: [BEAM-9322]
[BEAM-1833] Better naming for composite transform output tags.
Posted by GitBox <gi...@apache.org>.
rohdesamuel commented on issue #11283: [BEAM-9322] [BEAM-1833] Better naming for composite transform output tags.
URL: https://github.com/apache/beam/pull/11283#issuecomment-611207545
> @rohdesamuel is this good to go?
LGTM, sorry I thought you had the ball.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] robertwb merged pull request #11283: [BEAM-9322] [BEAM-1833]
Better naming for composite transform output tags.
Posted by GitBox <gi...@apache.org>.
robertwb merged pull request #11283: [BEAM-9322] [BEAM-1833] Better naming for composite transform output tags.
URL: https://github.com/apache/beam/pull/11283
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [beam] robertwb commented on issue #11283: [BEAM-9322] [BEAM-1833]
Better naming for composite transform output tags.
Posted by GitBox <gi...@apache.org>.
robertwb commented on issue #11283: [BEAM-9322] [BEAM-1833] Better naming for composite transform output tags.
URL: https://github.com/apache/beam/pull/11283#issuecomment-607960807
Run Portable_Python PreCommit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services