[jira] [Commented] (IGNITE-10988) Zookeeper test case testCommunicationFailureResolve_KillRandom frequently fails in GridAbstractTest.waitForTopology

["Ivan Daschinskiy (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-10988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218574#comment-17218574 ] 

Ivan Daschinskiy commented on IGNITE-10988:
-------------------------------------------

This is not bug, this failure is caused by [IGNITE-9493|https://issues.apache.org/jira/browse/IGNITE-9493]. 
On each iteration new node type is randomly chosen (client or server), but after changes in ticket mentioned above,
we currently don't create communication error resolver process for clients. So set is not properly cleaned. Also, it should be concurrent set.
I checked with implicit clean of {{org.apache.ignite.spi.discovery.zk.internal.ZookeeperDiscoveryCommunicationFailureTest.KillRandomCommunicationFailureResolver#LAST_KILLED_NODES}} on each iteration, changed it to concurrent set and I successfully run it locally 20 of 20 times.

> Zookeeper test case testCommunicationFailureResolve_KillRandom frequently fails in GridAbstractTest.waitForTopology
> -------------------------------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-10988
>                 URL: https://issues.apache.org/jira/browse/IGNITE-10988
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 2.7
>            Reporter: Oleg Ignatenko
>            Priority: Major
>              Labels: MakeTeamcityGreenAgain
>
> Zookeeper test case testCommunicationFailureResolve_KillRandom frequently fails in GridAbstractTest.waitForTopology.
> Teamcity test history in master currently shows "Test runs: 625 total / 251 failures" ([link|https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=-3849782382784091413&tab=testDetails).
> Need to find out why is that and whether test case can be improved and made more reliable.
> Typical failure message looks as follows:
> {noformat}
> [2019-01-18 06:57:23,489][ERROR][main][root] Test failed.
> junit.framework.AssertionFailedError
> 	at junit.framework.Assert.fail(Assert.java:55)
> 	at junit.framework.Assert.assertTrue(Assert.java:22)
> 	at junit.framework.Assert.assertTrue(Assert.java:31)
> 	at org.apache.ignite.testframework.junits.GridAbstractTest.waitForTopology(GridAbstractTest.java:2294)
> 	at org.apache.ignite.spi.discovery.zk.internal.ZookeeperDiscoverySpiTest.waitForTopology(ZookeeperDiscoverySpiTest.java:5103)
> 	at org.apache.ignite.spi.discovery.zk.internal.ZookeeperDiscoverySpiTest.testCommunicationFailureResolve_KillRandom(ZookeeperDiscoverySpiTest.java:3145)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:498)
> 	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:47)
> 	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> 	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:44)
> 	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> 	at org.apache.ignite.testframework.junits.GridAbstractTest$6.run(GridAbstractTest.java:2088)
> 	at java.lang.Thread.run(Thread.java:748){noformat}
> ----
> Side note per IGNITE-10777 this test case has moved to another class, from {{ZookeeperDiscoverySpiTest}} to {{ZookeeperDiscoverySpiTest5}} (which was further renamed to {{ZookeeperDiscoveryCommunicationFailureTest}}) but that didn't change anything: it still fails frequently and failure message is the same, with the only difference in the new test class name.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)