You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2023/01/12 21:59:31 UTC

[GitHub] [pulsar] lhotari opened a new pull request, #19219: [improve][ci] Limit cache step to 5 minutes to fail faster when it gets stuck

lhotari opened a new pull request, #19219:
URL: https://github.com/apache/pulsar/pull/19219

   ### Motivation
   
   The cache step in GitHub Actions workflows gets sometimes stuck.
   
   Example at https://github.com/apache/pulsar/actions/runs/3905696188/jobs/6673646325#step:6:17
   ```
   Received 1493610815 of 1497805119 (99.7%), 0.5 MBs/sec
   Received 1493610815 of 1497805119 (99.7%), 0.5 MBs/sec
   Received 1493610815 of 1497805119 (99.7%), 0.5 MBs/sec
   Received 1493610815 of 1497805119 (99.7%), 0.5 MBs/sec
   Received 1493610815 of 1497805119 (99.7%), 0.5 MBs/sec
   Received 1493610815 of 1497805119 (99.7%), 0.5 MBs/sec
   Received 1493610815 of 1497805119 (99.7%), 0.5 MBs/sec
   Received 1493610815 of 1497805119 (99.7%), 0.5 MBs/sec
   Error: The operation was canceled.
   ```
   The cache step runs until the job times out after 60 minutes. 
   
   ### Modifications
   
   Add `timeout-minutes: 5` to cache steps to limit the execution time to 5 minutes.
   
   ### Documentation
   
   <!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
   
   - [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
   - [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
   - [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
   - [ ] `doc-complete` <!-- Docs have been already added -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] codecov-commenter commented on pull request #19219: [improve][ci] Limit cache step to 5 minutes to fail faster when it gets stuck

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #19219:
URL: https://github.com/apache/pulsar/pull/19219#issuecomment-1381059159

   # [Codecov](https://codecov.io/gh/apache/pulsar/pull/19219?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#19219](https://codecov.io/gh/apache/pulsar/pull/19219?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d8f256d) into [master](https://codecov.io/gh/apache/pulsar/commit/d7f8f56b5be5ad34cf1d33dd89b7bfc6a9ab94ff?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d7f8f56) will **decrease** coverage by `10.55%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/pulsar/pull/19219/graphs/tree.svg?width=650&height=150&src=pr&token=acYqCpsK9J&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/pulsar/pull/19219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master   #19219       +/-   ##
   =============================================
   - Coverage     47.89%   37.33%   -10.56%     
   + Complexity    10871     1994     -8877     
   =============================================
     Files           713      209      -504     
     Lines         69730    14453    -55277     
     Branches       7496     1576     -5920     
   =============================================
   - Hits          33394     5396    -27998     
   + Misses        32631     8476    -24155     
   + Partials       3705      581     -3124     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | unittests | `37.33% <0.00%> (-10.56%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/pulsar/pull/19219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...va/org/apache/pulsar/client/impl/ProducerImpl.java](https://codecov.io/gh/apache/pulsar/pull/19219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL1Byb2R1Y2VySW1wbC5qYXZh) | `15.62% <0.00%> (-0.04%)` | :arrow_down: |
   | [...apache/pulsar/client/impl/AutoClusterFailover.java](https://codecov.io/gh/apache/pulsar/pull/19219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2NsaWVudC9pbXBsL0F1dG9DbHVzdGVyRmFpbG92ZXIuamF2YQ==) | `75.55% <0.00%> (-0.56%)` | :arrow_down: |
   | [...er/mledger/intercept/ManagedLedgerInterceptor.java](https://codecov.io/gh/apache/pulsar/pull/19219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbnRlcmNlcHQvTWFuYWdlZExlZGdlckludGVyY2VwdG9yLmphdmE=) | | |
   | [...n/coordinator/TransactionCoordinatorException.java](https://codecov.io/gh/apache/pulsar/pull/19219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci90cmFuc2FjdGlvbi9leGNlcHRpb24vY29vcmRpbmF0b3IvVHJhbnNhY3Rpb25Db29yZGluYXRvckV4Y2VwdGlvbi5qYXZh) | | |
   | [...sar/broker/loadbalance/impl/LoadManagerShared.java](https://codecov.io/gh/apache/pulsar/pull/19219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9sb2FkYmFsYW5jZS9pbXBsL0xvYWRNYW5hZ2VyU2hhcmVkLmphdmE=) | | |
   | [.../java/org/apache/pulsar/broker/admin/v3/Sinks.java](https://codecov.io/gh/apache/pulsar/pull/19219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9hZG1pbi92My9TaW5rcy5qYXZh) | | |
   | [...ookkeeper/mledger/impl/PositionImplRecyclable.java](https://codecov.io/gh/apache/pulsar/pull/19219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWFuYWdlZC1sZWRnZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Jvb2trZWVwZXIvbWxlZGdlci9pbXBsL1Bvc2l0aW9uSW1wbFJlY3ljbGFibGUuamF2YQ==) | | |
   | [...org/apache/pulsar/broker/stats/DimensionStats.java](https://codecov.io/gh/apache/pulsar/pull/19219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zdGF0cy9EaW1lbnNpb25TdGF0cy5qYXZh) | | |
   | [...ion/pendingack/TransactionPendingAckException.java](https://codecov.io/gh/apache/pulsar/pull/19219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci90cmFuc2FjdGlvbi9leGNlcHRpb24vcGVuZGluZ2Fjay9UcmFuc2FjdGlvblBlbmRpbmdBY2tFeGNlcHRpb24uamF2YQ==) | | |
   | [...r/service/schema/JsonSchemaCompatibilityCheck.java](https://codecov.io/gh/apache/pulsar/pull/19219?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHVsc2FyLWJyb2tlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcHVsc2FyL2Jyb2tlci9zZXJ2aWNlL3NjaGVtYS9Kc29uU2NoZW1hQ29tcGF0aWJpbGl0eUNoZWNrLmphdmE=) | | |
   | ... and [498 more](https://codecov.io/gh/apache/pulsar/pull/19219?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari commented on pull request #19219: [improve][ci] Limit cache step to 5 minutes to fail faster when it gets stuck

Posted by GitBox <gi...@apache.org>.
lhotari commented on PR #19219:
URL: https://github.com/apache/pulsar/pull/19219#issuecomment-1381045171

   another case where this issue is happening: https://github.com/apache/pulsar/actions/runs/3905806139/jobs/6674164947#step:6:1875


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [pulsar] lhotari merged pull request #19219: [improve][ci] Limit cache step to 5 minutes to fail faster when it gets stuck

Posted by GitBox <gi...@apache.org>.
lhotari merged PR #19219:
URL: https://github.com/apache/pulsar/pull/19219


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org