[GitHub] [druid] gianm commented on issue #9111: Add HashJoinSegment, a virtual segment for joins.

[GitBox <gi...@apache.org>]

gianm commented on issue #9111: Add HashJoinSegment, a virtual segment for joins.
URL: https://github.com/apache/druid/pull/9111#issuecomment-569756152
 
 
   > This is super cool thank you for putting this together. I would love to see a `README.md` (or similar) going over the high level mechanics of the join to help understand its limitations. I see a few comments scattered among classes but don't quite see the high level data flow. Is it all captured in #8728 , or are there more nuances in this PR since it is a foundation PR?
   
   @drcrallen --
   
   #8728 is more of a program for starting to build join support than a description of mechanics. I agree that such a description of mechanics would be useful, although I haven't written it yet. I will start working on that and, maybe, it will outlive the proposal #8728 in usefulness.
   
   What sorts of questions would you want this mechanical description / design doc to answer?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org