You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@wicket.apache.org by Sven Meier <sv...@meiers.net> on 2020/10/28 22:00:44 UTC

new release 9.2.0 ?

Hi all,

wicket-9.x got some important fixes, so we should release a 9.2.0 soon.

WDYT?

Sven

Re: new release 9.2.0 ?

Posted by Ernesto Reinaldo Barreiro <re...@gmail.com>.

Hi Emond,

We are getting on our tests

2020-10-27 01:47:43 ERROR [http-nio-8080-exec-5] ListenerCollection - Error
invoking listener: org.apache.wicket.Application$2@8a11872
java.lang.IllegalStateException: Cannot create a session after the response
has been committed at
org.apache.catalina.connector.Request.doGetSession(Request.java:2999) at
org.apache.catalina.connector.Request.getSession(Request.java:2441) at
org.apache.catalina.connector.RequestFacade.getSession(RequestFacade.java:908)
at
javax.servlet.http.HttpServletRequestWrapper.getSession(HttpServletRequestWrapper.java:244)
at
org.apache.shiro.web.servlet.ShiroHttpServletRequest.getSession(ShiroHttpServletRequest.java:148)
at
org.apache.wicket.session.HttpSessionStore.getHttpSession(HttpSessionStore.java:85)
at
org.apache.wicket.session.HttpSessionStore.getSessionId(HttpSessionStore.java:146)
at org.apache.wicket.Session.bind(Session.java:276) at
org.apache.wicket.pageStore.DefaultPageContext.getSessionId(DefaultPageContext.java:44)
at
org.apache.wicket.pageStore.AsynchronousPageStore$PendingAdd.<init>(AsynchronousPageStore.java:150)
at
org.apache.wicket.pageStore.AsynchronousPageStore.addPage(AsynchronousPageStore.java:368)
at
org.apache.wicket.pageStore.SerializingPageStore.addPage(SerializingPageStore.java:82)
at
org.apache.wicket.pageStore.CachingPageStore.addPage(CachingPageStore.java:73)
at
org.apache.wicket.pageStore.RequestPageStore.detach(RequestPageStore.java:108)
at org.apache.wicket.page.PageMana

Hopefully I will be able to check today if

https://issues.apache.org/jira/browse/WICKET-6847

fixes the issue.

On Fri, Oct 30, 2020 at 11:39 AM Emond Papegaaij <em...@gmail.com>
wrote:

> -1 to start the release now. We just discovered a (very likely) new
> issue with the flush before detach:
> https://issues.apache.org/jira/browse/WICKET-6848
>
> We are currently checking if the changes made with WICKET-6847 fix
> this, but I think this is a different problem. Maybe someone with a
> bit more knowledge about the session invalidation can give a hint?
>
> Best regards,
> Emond
>
> On Thu, Oct 29, 2020 at 11:09 AM Thomas Heigl <th...@umschalt.com> wrote:
> >
> > +1
> >
> > On Thu, Oct 29, 2020 at 8:32 AM Ernesto Reinaldo Barreiro <
> > reiern70@gmail.com> wrote:
> >
> > > +1
> > >
> > > On Thu, Oct 29, 2020 at 3:54 AM Maxim Solodovnik <solomax666@gmail.com
> >
> > > wrote:
> > >
> > > > +1
> > > > fixes to PageSerializers are worth to be released! :))
> > > >
> > > > And maybe it's time to start Wicket10? or maybe collect ideas :))
> > > >
> > > > On Thu, 29 Oct 2020 at 06:30, Tobias Soloschenko
> > > > <to...@googlemail.com.invalid> wrote:
> > > >
> > > > > +1 for release
> > > > >
> > > > > kind regards
> > > > >
> > > > > Tobias
> > > > >
> > > > > > Am 28.10.2020 um 23:27 schrieb Sven Meier <sv...@meiers.net>:
> > > > > >
> > > > > > Hi all,
> > > > > >
> > > > > > wicket-9.x got some important fixes, so we should release a 9.2.0
> > > soon.
> > > > > >
> > > > > > WDYT?
> > > > > >
> > > > > > Sven
> > > > > >
> > > > >
> > > >
> > > >
> > > > --
> > > > Best regards,
> > > > Maxim
> > > >
> > >
> > >
> > > --
> > > Regards - Ernesto Reinaldo Barreiro
> > >
>


-- 
Regards - Ernesto Reinaldo Barreiro

Re: new release 9.2.0 ?

Posted by Emond Papegaaij <em...@gmail.com>.

-1 to start the release now. We just discovered a (very likely) new
issue with the flush before detach:
https://issues.apache.org/jira/browse/WICKET-6848

We are currently checking if the changes made with WICKET-6847 fix
this, but I think this is a different problem. Maybe someone with a
bit more knowledge about the session invalidation can give a hint?

Best regards,
Emond

On Thu, Oct 29, 2020 at 11:09 AM Thomas Heigl <th...@umschalt.com> wrote:
>
> +1
>
> On Thu, Oct 29, 2020 at 8:32 AM Ernesto Reinaldo Barreiro <
> reiern70@gmail.com> wrote:
>
> > +1
> >
> > On Thu, Oct 29, 2020 at 3:54 AM Maxim Solodovnik <so...@gmail.com>
> > wrote:
> >
> > > +1
> > > fixes to PageSerializers are worth to be released! :))
> > >
> > > And maybe it's time to start Wicket10? or maybe collect ideas :))
> > >
> > > On Thu, 29 Oct 2020 at 06:30, Tobias Soloschenko
> > > <to...@googlemail.com.invalid> wrote:
> > >
> > > > +1 for release
> > > >
> > > > kind regards
> > > >
> > > > Tobias
> > > >
> > > > > Am 28.10.2020 um 23:27 schrieb Sven Meier <sv...@meiers.net>:
> > > > >
> > > > > Hi all,
> > > > >
> > > > > wicket-9.x got some important fixes, so we should release a 9.2.0
> > soon.
> > > > >
> > > > > WDYT?
> > > > >
> > > > > Sven
> > > > >
> > > >
> > >
> > >
> > > --
> > > Best regards,
> > > Maxim
> > >
> >
> >
> > --
> > Regards - Ernesto Reinaldo Barreiro
> >

Re: new release 9.2.0 ?

Posted by Thomas Heigl <th...@umschalt.com>.

+1

On Thu, Oct 29, 2020 at 8:32 AM Ernesto Reinaldo Barreiro <
reiern70@gmail.com> wrote:

> +1
>
> On Thu, Oct 29, 2020 at 3:54 AM Maxim Solodovnik <so...@gmail.com>
> wrote:
>
> > +1
> > fixes to PageSerializers are worth to be released! :))
> >
> > And maybe it's time to start Wicket10? or maybe collect ideas :))
> >
> > On Thu, 29 Oct 2020 at 06:30, Tobias Soloschenko
> > <to...@googlemail.com.invalid> wrote:
> >
> > > +1 for release
> > >
> > > kind regards
> > >
> > > Tobias
> > >
> > > > Am 28.10.2020 um 23:27 schrieb Sven Meier <sv...@meiers.net>:
> > > >
> > > > Hi all,
> > > >
> > > > wicket-9.x got some important fixes, so we should release a 9.2.0
> soon.
> > > >
> > > > WDYT?
> > > >
> > > > Sven
> > > >
> > >
> >
> >
> > --
> > Best regards,
> > Maxim
> >
>
>
> --
> Regards - Ernesto Reinaldo Barreiro
>

Re: new release 9.2.0 ?

Posted by Ernesto Reinaldo Barreiro <re...@gmail.com>.

+1

On Thu, Oct 29, 2020 at 3:54 AM Maxim Solodovnik <so...@gmail.com>
wrote:

> +1
> fixes to PageSerializers are worth to be released! :))
>
> And maybe it's time to start Wicket10? or maybe collect ideas :))
>
> On Thu, 29 Oct 2020 at 06:30, Tobias Soloschenko
> <to...@googlemail.com.invalid> wrote:
>
> > +1 for release
> >
> > kind regards
> >
> > Tobias
> >
> > > Am 28.10.2020 um 23:27 schrieb Sven Meier <sv...@meiers.net>:
> > >
> > > Hi all,
> > >
> > > wicket-9.x got some important fixes, so we should release a 9.2.0 soon.
> > >
> > > WDYT?
> > >
> > > Sven
> > >
> >
>
>
> --
> Best regards,
> Maxim
>


-- 
Regards - Ernesto Reinaldo Barreiro

Re: new release 9.2.0 ?

Posted by Maxim Solodovnik <so...@gmail.com>.

+1
fixes to PageSerializers are worth to be released! :))

And maybe it's time to start Wicket10? or maybe collect ideas :))

On Thu, 29 Oct 2020 at 06:30, Tobias Soloschenko
<to...@googlemail.com.invalid> wrote:

> +1 for release
>
> kind regards
>
> Tobias
>
> > Am 28.10.2020 um 23:27 schrieb Sven Meier <sv...@meiers.net>:
> >
> > Hi all,
> >
> > wicket-9.x got some important fixes, so we should release a 9.2.0 soon.
> >
> > WDYT?
> >
> > Sven
> >
>

-- 
Best regards,
Maxim

Re: new release 9.2.0 ?

Posted by Tobias Soloschenko <to...@googlemail.com.INVALID>.

+1 for release

kind regards

Tobias

> Am 28.10.2020 um 23:27 schrieb Sven Meier <sv...@meiers.net>:
> 
> Hi all,
> 
> wicket-9.x got some important fixes, so we should release a 9.2.0 soon.
> 
> WDYT?
> 
> Sven
>