You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by agamemnus <gi...@git.apache.org> on 2014/09/11 18:11:34 UTC
[GitHub] cordova-plugin-media pull request: Added fp.exists () false negati...
GitHub user agamemnus opened a pull request:
https://github.com/apache/cordova-plugin-media/pull/27
Added fp.exists () false negative shield.
The Media API doesn't account for cases where fp.exists() may provide a false negative. (For example, APK expansions...)
Cosmetic: I also did a short-circuit on the first condition, converted to "} else {"s instead of hanging brackets, and fixed the incorrect spacing in the last few lines. (caused probably by the hanging brackets!)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/agamemnus/cordova-plugin-media master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media/pull/27.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #27
----
commit 6fd5193225c291a11b65e6a261b0974a30e30e8d
Author: agamemnus <ag...@gmail.com>
Date: 2014-09-11T16:10:10Z
Added fp.exists () false negative shield.
The Media API doesn't account for cases where fp.exists() may provide a false negative. (For example, APK expansions...)
Cosmetic: I also did a short-circuit on the first condition, converted to "} else {"s instead of hanging brackets, and fixed the incorrect spacing in the last few lines. (caused probably by the hanging brackets!)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-media pull request: Added fp.exists () false negati...
Posted by cordova-qa <gi...@git.apache.org>.
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/27#issuecomment-219898952
Cordova CI Build has one or more failures.
**Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/27/commits/6fd5193225c291a11b65e6a261b0974a30e30e8d)
**Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/15/)
| Builder Name | Console Output | Test Report | Device Logs |
| :---: | :---: | :---: | :---: |
| [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/15//label=windows-slave,platformName=windows-8.1-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/15//label=windows-slave,platformName=windows-8.1-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/15//label=windows-slave,platformName=windows-8.1-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/15//label=windows-slave,platformName=windows-8.1-store/artifact/) |
| [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/15//label=windows-slave,platformName=windows-10-store/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/15//label=windows-slave,platformName=windows-10-store/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/15//label=windows-slave,platformName=windows-10-store/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/15//label=windows-slave,platformName=windows-10-store/artifact/) |
| [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/15//label=windows-slave,platformName=windows-8.1-phone/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/15//label=windows-slave,platformName=windows-8.1-phone/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/15//label=windows-slave,platformName=windows-8.1-phone/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/15//label=windows-slave,platformName=windows-8.1-phone/artifact/) |
| [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/15//label=mac-slave,platformName=ios/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/15//label=mac-slave,platformName=ios/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/15//label=mac-slave,platformName=ios/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/15//label=mac-slave,platformName=ios/artifact/) |
| [Android Mac]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/15//label=mac-slave,platformName=android/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/15//label=mac-slave,platformName=android/console) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/15//label=mac-slave,platformName=android/testReport/) | [Link]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-pr/15//label=mac-slave,platformName=android/artifact/) |
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Added fp.exists () false negati...
Posted by agamemnus <gi...@git.apache.org>.
Github user agamemnus commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/27#issuecomment-68575457
I got the email back saying it was received.
https://issues.apache.org/jira/secure/Dashboard.jspa doesn't want to load.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Added fp.exists () false negati...
Posted by agamemnus <gi...@git.apache.org>.
Github user agamemnus commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/27#issuecomment-81339170
vispo, you can use Crosswalk and do ``xwalk --disable-gesture-requirement-for-media-playback`` in ``platforms\android\assets\xwalk-command-line``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Added fp.exists () false negati...
Posted by vispo <gi...@git.apache.org>.
Github user vispo commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/27#issuecomment-81347091
I hear that Amazon allows Android apps up to 150mb in size. I could probably get away without having to use an expansion file if we distribute it through Amazon rather than the Google Play Store. Have you distributed an Android app through Amazon? Is it OK? Limitations?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Added fp.exists () false negati...
Posted by vispo <gi...@git.apache.org>.
Github user vispo commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/27#issuecomment-81340039
Have never heard of Crosswalk before. I see it at https://crosswalk-project.org . Is it a Phonegap plugin or something entirely separate from Phonegap?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Added fp.exists () false negati...
Posted by agamemnus <gi...@git.apache.org>.
Github user agamemnus commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/27#issuecomment-219899404
Hard to see.... too many links....
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Added fp.exists () false negati...
Posted by agamemnus <gi...@git.apache.org>.
Github user agamemnus commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/27#issuecomment-81371726
I have not tried using Amazon to publish my game.
Crosswalk is a system that adds a standalone version of Chromium to your Android Cordova app or game. It's only a few steps to use it via the "migrate" option and it is well-supported by Intel and a growing base of users.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Added fp.exists () false negati...
Posted by vispo <gi...@git.apache.org>.
Github user vispo commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/27#issuecomment-81335276
I am still in shock reading that you can't use Android expansion files with the Cordova Media plugin to play sounds. I have a 150mb project that uses a lot of sound and I've developed it using the Media plugin. Is it true that you can't use the Media plugin with Android expansion files??? What to do???
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Added fp.exists () false negati...
Posted by agamemnus <gi...@git.apache.org>.
Github user agamemnus commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/27#issuecomment-55302293
Actually, I am not entirely sure why ``FileInputStream fileInputStream = new FileInputStream(file)`` isn't used for the second case of ``Environment.getExternalStorageDirectory().getPath() + "/" + file``... was that a bug, also?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugin-media pull request: Added fp.exists () false negati...
Posted by agamemnus <gi...@git.apache.org>.
Github user agamemnus commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/27#issuecomment-66182323
I sent in a signed and scanned ICLA to Apache's secretary email.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Added fp.exists () false negati...
Posted by agamemnus <gi...@git.apache.org>.
Github user agamemnus commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/27#issuecomment-64913187
Gee, that ICLA thing is pretty formal. I'll email that ASAP...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Added fp.exists () false negati...
Posted by clelland <gi...@git.apache.org>.
Github user clelland commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/27#issuecomment-64911566
It may have been a bug; I like the way that you've done it, though, regardless.
Do you have an ICLA on file with Apache? I can't tell by your Github username. Also, I'd like to have an issue on our JIRA tracker (https://issues.apache.org/jira) for it for future reference.
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media pull request: Added fp.exists () false negati...
Posted by pniraula <gi...@git.apache.org>.
Github user pniraula commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/27#issuecomment-81338642
@vispo and there seems to be some problem with android 5.0 and media plugin. I am working in a project which uses media plugin to play audio. The application works well in all versions of android but 5.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org