Re: [PR] Fixes all race conditions from stream consumer [pinot]

["noob-se7en (via GitHub)" <gi...@apache.org>]

noob-se7en commented on code in PR #17089:
URL: https://github.com/apache/pinot/pull/17089#discussion_r2486400031


##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##########
@@ -248,6 +259,23 @@ public boolean getAsBoolean() {
     }
   }
 
+  @VisibleForTesting
+  protected Cache<String, StreamMetadataProvider> getStreamMetadataProviderCache() {
+    return CacheBuilder.newBuilder()
+        .expireAfterAccess(STREAM_METADATA_PROVIDER_CACHE_TTL)
+        .removalListener((RemovalNotification<String, StreamMetadataProvider> notification) -> {
+          StreamMetadataProvider provider = notification.getValue();

Review Comment:
   right now not handling that case. Will look into it we encounter it I don't see need for now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org