[jira] [Commented] (THRIFT-1860) AbstractNonBlockingServer never opens transport

["Vitali Lovich (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-1860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13583554#comment-13583554 ] 

Vitali Lovich commented on THRIFT-1860:
---------------------------------------

hmmm... this may be more complicated than I thought.  The underlying transport is open thus it would actually be incorrect to open it again.  It's unclear though how to handle this condition; I need to be able to potentially throw a TException in getProcessor in a custom processor factory (since I read off authentication data & need to validate) but I'm unable to do so.  Maybe getProcessor should be allowed to throw a TException in TProcessorFactory? 
                
> AbstractNonBlockingServer never opens transport
> -----------------------------------------------
>
>                 Key: THRIFT-1860
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1860
>             Project: Thrift
>          Issue Type: Bug
>          Components: Java - Library
>    Affects Versions: 0.9, 1.0
>            Reporter: Vitali Lovich
>
> AbstractNonblockingServer.FrameBuffer#invoke never opens the transport before passing it to the processor.  The first line of the try{} should be a call to open the underlying transport.  I tried to add logic that had an authentication frame as the first frame but it didn't work because the transport isn't open.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira