[GitHub] [qpid-proton] grs commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects

[GitBox <gi...@apache.org>]

grs commented on a change in pull request #213: PROTON-2140: Lazy creation of various link related objects
URL: https://github.com/apache/qpid-proton/pull/213#discussion_r349303323
 
 

 ##########
 File path: c/src/core/codec.c
 ##########
 @@ -364,37 +364,72 @@ static int pn_data_inspect(void *obj, pn_string_t *dst)
 #define pn_data_hashcode NULL
 #define pn_data_compare NULL
 
-pn_data_t *pn_data(size_t capacity)
+pn_data_t *pni_data(size_t capacity, size_t initial_buffer)
 
 Review comment:
   That is probably just an artefact of the evolution of the patch. Initialy I began by allocating an empty buffer rather than 64 bytes, but then went further. I'll remove the extra function.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org