You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "ryan rawson (JIRA)" <ji...@apache.org> on 2009/07/24 22:45:14 UTC

[jira] Created: (HBASE-1703) ICVs across /during a flush can cause multiple keys with the same TS (bad)

ICVs across /during a flush can cause multiple keys with the same TS (bad)
--------------------------------------------------------------------------

                 Key: HBASE-1703
                 URL: https://issues.apache.org/jira/browse/HBASE-1703
             Project: Hadoop HBase
          Issue Type: Bug
    Affects Versions: 0.20.0
            Reporter: ryan rawson
            Priority: Critical
             Fix For: 0.20.0


We noticed a bug whereby the value in a hbase ICV'ed counter was lower, and the bug turned out to be that during a flush, the ICV will grab the KeyValue from 'memcache' and reuse the timestamp... if we grab the KeyValue from the _snapshot_ we end up with 2 key values, one in memcache, one in a hfile, both with the same timestamp, but one with a lower value than the other.

The fix is to not reuse timestamps if they come out of the snapshot.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (HBASE-1703) ICVs across /during a flush can cause multiple keys with the same TS (bad)

Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ryan rawson resolved HBASE-1703.
--------------------------------

    Resolution: Fixed

commited the change myself w/o review.

> ICVs across /during a flush can cause multiple keys with the same TS (bad)
> --------------------------------------------------------------------------
>
>                 Key: HBASE-1703
>                 URL: https://issues.apache.org/jira/browse/HBASE-1703
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: ryan rawson
>            Assignee: ryan rawson
>            Priority: Critical
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1703.patch
>
>
> We noticed a bug whereby the value in a hbase ICV'ed counter was lower, and the bug turned out to be that during a flush, the ICV will grab the KeyValue from 'memcache' and reuse the timestamp... if we grab the KeyValue from the _snapshot_ we end up with 2 key values, one in memcache, one in a hfile, both with the same timestamp, but one with a lower value than the other.
> The fix is to not reuse timestamps if they come out of the snapshot.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HBASE-1703) ICVs across /during a flush can cause multiple keys with the same TS (bad)

Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ryan rawson updated HBASE-1703:
-------------------------------

    Attachment: HBASE-1703.patch

new test to cover the edge case

> ICVs across /during a flush can cause multiple keys with the same TS (bad)
> --------------------------------------------------------------------------
>
>                 Key: HBASE-1703
>                 URL: https://issues.apache.org/jira/browse/HBASE-1703
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: ryan rawson
>            Assignee: ryan rawson
>            Priority: Critical
>             Fix For: 0.20.0
>
>         Attachments: HBASE-1703.patch
>
>
> We noticed a bug whereby the value in a hbase ICV'ed counter was lower, and the bug turned out to be that during a flush, the ICV will grab the KeyValue from 'memcache' and reuse the timestamp... if we grab the KeyValue from the _snapshot_ we end up with 2 key values, one in memcache, one in a hfile, both with the same timestamp, but one with a lower value than the other.
> The fix is to not reuse timestamps if they come out of the snapshot.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HBASE-1703) ICVs across /during a flush can cause multiple keys with the same TS (bad)

Posted by "ryan rawson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-1703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

ryan rawson reassigned HBASE-1703:
----------------------------------

    Assignee: ryan rawson

> ICVs across /during a flush can cause multiple keys with the same TS (bad)
> --------------------------------------------------------------------------
>
>                 Key: HBASE-1703
>                 URL: https://issues.apache.org/jira/browse/HBASE-1703
>             Project: Hadoop HBase
>          Issue Type: Bug
>    Affects Versions: 0.20.0
>            Reporter: ryan rawson
>            Assignee: ryan rawson
>            Priority: Critical
>             Fix For: 0.20.0
>
>
> We noticed a bug whereby the value in a hbase ICV'ed counter was lower, and the bug turned out to be that during a flush, the ICV will grab the KeyValue from 'memcache' and reuse the timestamp... if we grab the KeyValue from the _snapshot_ we end up with 2 key values, one in memcache, one in a hfile, both with the same timestamp, but one with a lower value than the other.
> The fix is to not reuse timestamps if they come out of the snapshot.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.