[GitHub] [incubator-eventmesh] yzhao244 commented on a change in pull request #498: [ISSUE #339] Design the architecture and interfaces of OpenSchema integration

[GitBox <gi...@apache.org>]

yzhao244 commented on a change in pull request #498:
URL: https://github.com/apache/incubator-eventmesh/pull/498#discussion_r690695481



##########
File path: settings.gradle
##########
@@ -25,4 +25,5 @@ include 'eventmesh-test'
 include 'eventmesh-spi'
 include 'eventmesh-connector-plugin:eventmesh-connector-api'
 include 'eventmesh-connector-plugin:eventmesh-connector-rocketmq'
+include 'eventmesh-rest'

Review comment:
       I think @ruanwenjun 's idea of creating eventmesh-openschema-rest under its own plugin is good. Basically, the plugin becomes very self-contained.. Regarding #435, I will update to suggest creating a new module called eventmesh-admin-plugin which contains its own eventmesh-admin-rest along with other dependencies.   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org