You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/03/31 19:11:00 UTC
Review Request 19852: Avoided unnecessary retries during log fill by using a
higher proposal number.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19852/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-1165
https://issues.apache.org/jira/browse/MESOS-1165
Repository: mesos-git
Description
-------
See MESOS-1165 for details.
Also added a test for capturing regression.
Diffs
-----
src/log/coordinator.cpp caa4b85
src/tests/log_tests.cpp b368cde
Diff: https://reviews.apache.org/r/19852/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 19852: Avoided unnecessary retries during log fill by
using a higher proposal number.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19852/
-----------------------------------------------------------
(Updated March 31, 2014, 10:31 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Review comments.
Bugs: MESOS-1165
https://issues.apache.org/jira/browse/MESOS-1165
Repository: mesos-git
Description
-------
See MESOS-1165 for details.
Also added a test for capturing regression.
Diffs (updated)
-----
src/log/coordinator.cpp caa4b85
src/tests/log_tests.cpp b368cde
Diff: https://reviews.apache.org/r/19852/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 19852: Avoided unnecessary retries during log fill by
using a higher proposal number.
Posted by Jie Yu <yu...@gmail.com>.
> On March 31, 2014, 10:12 p.m., Jiang Yan Xu wrote:
> > src/log/coordinator.cpp, line 235
> > <https://reviews.apache.org/r/19852/diff/1/?file=542427#file542427line235>
> >
> > No biggie, just not sure if it's abundantly clear from the code or comments elsewhere that we don't need to update CoordiantorProcess::proposal because we are catching up "previous" positions thus won't mess up with the implicit promises for future positions.
Updated the comments.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19852/#review39112
-----------------------------------------------------------
On March 31, 2014, 5:10 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19852/
> -----------------------------------------------------------
>
> (Updated March 31, 2014, 5:10 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1165
> https://issues.apache.org/jira/browse/MESOS-1165
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See MESOS-1165 for details.
>
> Also added a test for capturing regression.
>
>
> Diffs
> -----
>
> src/log/coordinator.cpp caa4b85
> src/tests/log_tests.cpp b368cde
>
> Diff: https://reviews.apache.org/r/19852/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 19852: Avoided unnecessary retries during log fill by
using a higher proposal number.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19852/#review39112
-----------------------------------------------------------
Ship it!
src/log/coordinator.cpp
<https://reviews.apache.org/r/19852/#comment71497>
No biggie, just not sure if it's abundantly clear from the code or comments elsewhere that we don't need to update CoordiantorProcess::proposal because we are catching up "previous" positions thus won't mess up with the implicit promises for future positions.
- Jiang Yan Xu
On March 31, 2014, 10:10 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19852/
> -----------------------------------------------------------
>
> (Updated March 31, 2014, 10:10 a.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1165
> https://issues.apache.org/jira/browse/MESOS-1165
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See MESOS-1165 for details.
>
> Also added a test for capturing regression.
>
>
> Diffs
> -----
>
> src/log/coordinator.cpp caa4b85
> src/tests/log_tests.cpp b368cde
>
> Diff: https://reviews.apache.org/r/19852/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 19852: Avoided unnecessary retries during log fill by
using a higher proposal number.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19852/#review39090
-----------------------------------------------------------
Ship it!
Thanks Jie!
src/log/coordinator.cpp
<https://reviews.apache.org/r/19852/#comment71479>
... that were just implicitly promised ...
Also, can we add something like the following (since it's not in the JIRA issue):
This is safe because log::catchup would increment the proposal number automatically after failing to fill implicitly promised positions and this just shortcuts that process.
- Benjamin Hindman
On March 31, 2014, 5:10 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19852/
> -----------------------------------------------------------
>
> (Updated March 31, 2014, 5:10 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1165
> https://issues.apache.org/jira/browse/MESOS-1165
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See MESOS-1165 for details.
>
> Also added a test for capturing regression.
>
>
> Diffs
> -----
>
> src/log/coordinator.cpp caa4b85
> src/tests/log_tests.cpp b368cde
>
> Diff: https://reviews.apache.org/r/19852/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 19852: Avoided unnecessary retries during log fill by
using a higher proposal number.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19852/#review39074
-----------------------------------------------------------
Patch looks great!
Reviews applied: [19852]
All tests passed.
- Mesos ReviewBot
On March 31, 2014, 5:10 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19852/
> -----------------------------------------------------------
>
> (Updated March 31, 2014, 5:10 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Bugs: MESOS-1165
> https://issues.apache.org/jira/browse/MESOS-1165
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See MESOS-1165 for details.
>
> Also added a test for capturing regression.
>
>
> Diffs
> -----
>
> src/log/coordinator.cpp caa4b85
> src/tests/log_tests.cpp b368cde
>
> Diff: https://reviews.apache.org/r/19852/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>