You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by Thomas Koch <th...@koch.ro> on 2011/09/09 17:49:23 UTC
Review Request: Remove dead code and basic cleanup in DataTree
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1772/
-----------------------------------------------------------
Review request for zookeeper.
Summary
-------
.
This addresses bug ZOOKEEPER-1176.
https://issues.apache.org/jira/browse/ZOOKEEPER-1176
Diffs
-----
src/java/main/org/apache/zookeeper/server/ZKDatabase.java 6bad5fc
src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java c085bfb
src/java/main/org/apache/zookeeper/server/DataNode.java 9498204
src/java/main/org/apache/zookeeper/server/DataTree.java 0690ce9
Diff: https://reviews.apache.org/r/1772/diff
Testing
-------
Thanks,
Thomas
Re: Review Request: ZOOKEEPER-1176 Remove dead code and basic cleanup in
DataTree
Posted by Thomas Koch <th...@koch.ro>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1772/
-----------------------------------------------------------
(Updated 2011-09-15 09:06:50.251249)
Review request for zookeeper.
Summary
-------
.
This addresses bug ZOOKEEPER-1176.
https://issues.apache.org/jira/browse/ZOOKEEPER-1176
Diffs (updated)
-----
src/java/main/org/apache/zookeeper/server/DataNode.java d839a74
src/java/main/org/apache/zookeeper/server/DataTree.java 27338d1
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java 96acdf6
src/java/main/org/apache/zookeeper/server/ZKDatabase.java 6bad5fc
src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 2d9b104
src/java/main/org/apache/zookeeper/server/quorum/LearnerHandler.java 9c28663
src/java/test/org/apache/zookeeper/test/FollowerResyncConcurrencyTest.java 2752d5c
src/java/test/org/apache/zookeeper/test/RestoreCommittedLogTest.java 9a9ff83
Diff: https://reviews.apache.org/r/1772/diff
Testing
-------
Thanks,
Thomas
Re: Review Request: ZOOKEEPER-1176 Remove dead code and basic cleanup in
DataTree
Posted by Thomas Koch <th...@koch.ro>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1772/
-----------------------------------------------------------
(Updated 2011-09-15 08:31:34.680636)
Review request for zookeeper.
Summary
-------
.
This addresses bug ZOOKEEPER-1176.
https://issues.apache.org/jira/browse/ZOOKEEPER-1176
Diffs (updated)
-----
src/java/main/org/apache/zookeeper/server/DataNode.java d839a74
src/java/main/org/apache/zookeeper/server/DataTree.java 27338d1
src/java/main/org/apache/zookeeper/server/ZKDatabase.java 6bad5fc
src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 2d9b104
Diff: https://reviews.apache.org/r/1772/diff
Testing
-------
Thanks,
Thomas
Re: Review Request: ZOOKEEPER-1176 Remove dead code and basic cleanup in
DataTree
Posted by Patrick Hunt <ph...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1772/
-----------------------------------------------------------
(Updated 2011-09-14 22:16:44.740700)
Review request for zookeeper.
Summary (updated)
-------
.
This addresses bug ZOOKEEPER-1176.
https://issues.apache.org/jira/browse/ZOOKEEPER-1176
Diffs
-----
src/java/main/org/apache/zookeeper/server/DataNode.java 9498204
src/java/main/org/apache/zookeeper/server/DataTree.java 3987c54
src/java/main/org/apache/zookeeper/server/ZKDatabase.java 6bad5fc
src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 2946030
Diff: https://reviews.apache.org/r/1772/diff
Testing
-------
Thanks,
Thomas
Re: Review Request: ZOOKEEPER-1176 Remove dead code and basic cleanup in
DataTree
Posted by Thomas Koch <th...@koch.ro>.
> On 2011-09-14 18:34:18, Patrick Hunt wrote:
> > src/java/main/org/apache/zookeeper/server/DataTree.java, line 160
> > <https://reviews.apache.org/r/1772/diff/3/?file=40496#file40496line160>
> >
> > while you're here, add javadoc?
I'm not ready yet with the DataTree. JavaDocs that I'd add now would get obsolete by the next patch.
> On 2011-09-14 18:34:18, Patrick Hunt wrote:
> > src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java, line 265
> > <https://reviews.apache.org/r/1772/diff/3/?file=40498#file40498line265>
> >
> > why is this dropped? (I didn't see it noted in the jira)
The setDataTreeInit method has been removed because it only did set the DataTree.initialized property which was never ever read again.
- Thomas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1772/#review1896
-----------------------------------------------------------
On 2011-09-15 08:31:34, Thomas Koch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1772/
> -----------------------------------------------------------
>
> (Updated 2011-09-15 08:31:34)
>
>
> Review request for zookeeper.
>
>
> Summary
> -------
>
> .
>
>
> This addresses bug ZOOKEEPER-1176.
> https://issues.apache.org/jira/browse/ZOOKEEPER-1176
>
>
> Diffs
> -----
>
> src/java/main/org/apache/zookeeper/server/DataNode.java d839a74
> src/java/main/org/apache/zookeeper/server/DataTree.java 27338d1
> src/java/main/org/apache/zookeeper/server/ZKDatabase.java 6bad5fc
> src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 2d9b104
>
> Diff: https://reviews.apache.org/r/1772/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas
>
>
Re: Review Request: Remove dead code and basic cleanup in DataTree
Posted by Patrick Hunt <ph...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1772/#review1896
-----------------------------------------------------------
Looks good to me with just a couple questions:
src/java/main/org/apache/zookeeper/server/DataTree.java
<https://reviews.apache.org/r/1772/#comment4377>
while you're here, add javadoc?
src/java/main/org/apache/zookeeper/server/DataTree.java
<https://reviews.apache.org/r/1772/#comment4378>
javadoc?
src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java
<https://reviews.apache.org/r/1772/#comment4379>
why is this dropped? (I didn't see it noted in the jira)
- Patrick
On 2011-09-14 10:12:15, Thomas Koch wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/1772/
> -----------------------------------------------------------
>
> (Updated 2011-09-14 10:12:15)
>
>
> Review request for zookeeper.
>
>
> Summary
> -------
>
> .
>
>
> This addresses bug ZOOKEEPER-1176.
> https://issues.apache.org/jira/browse/ZOOKEEPER-1176
>
>
> Diffs
> -----
>
> src/java/main/org/apache/zookeeper/server/DataNode.java 9498204
> src/java/main/org/apache/zookeeper/server/DataTree.java 3987c54
> src/java/main/org/apache/zookeeper/server/ZKDatabase.java 6bad5fc
> src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 2946030
>
> Diff: https://reviews.apache.org/r/1772/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Thomas
>
>
Re: Review Request: Remove dead code and basic cleanup in DataTree
Posted by Thomas Koch <th...@koch.ro>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1772/
-----------------------------------------------------------
(Updated 2011-09-14 10:12:15.541246)
Review request for zookeeper.
Summary
-------
.
This addresses bug ZOOKEEPER-1176.
https://issues.apache.org/jira/browse/ZOOKEEPER-1176
Diffs (updated)
-----
src/java/main/org/apache/zookeeper/server/DataNode.java 9498204
src/java/main/org/apache/zookeeper/server/DataTree.java 3987c54
src/java/main/org/apache/zookeeper/server/ZKDatabase.java 6bad5fc
src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 2946030
Diff: https://reviews.apache.org/r/1772/diff
Testing
-------
Thanks,
Thomas
Re: Review Request: Remove dead code and basic cleanup in DataTree
Posted by Thomas Koch <th...@koch.ro>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1772/
-----------------------------------------------------------
(Updated 2011-09-14 07:23:57.897945)
Review request for zookeeper.
Summary
-------
.
This addresses bug ZOOKEEPER-1176.
https://issues.apache.org/jira/browse/ZOOKEEPER-1176
Diffs (updated)
-----
src/java/main/org/apache/zookeeper/server/DataNode.java 9498204
src/java/main/org/apache/zookeeper/server/DataTree.java 3987c54
src/java/main/org/apache/zookeeper/server/ZKDatabase.java 6bad5fc
src/java/main/org/apache/zookeeper/server/ZooKeeperServer.java 2946030
Diff: https://reviews.apache.org/r/1772/diff
Testing
-------
Thanks,
Thomas