You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ma...@apache.org on 2014/02/03 22:25:39 UTC

svn commit: r1564068 - in /commons/proper/dbcp/branches/DBCP_1_5_x_BRANCH/src: changes/changes.xml main/java/org/apache/commons/dbcp/PoolableConnection.java

Author: markt
Date: Mon Feb  3 21:25:39 2014
New Revision: 1564068

URL: http://svn.apache.org/r1564068
Log:
Fix DBCP-398
Clarify Jaavdoc for isClosed() method of PoolableConnection.

Modified:
    commons/proper/dbcp/branches/DBCP_1_5_x_BRANCH/src/changes/changes.xml
    commons/proper/dbcp/branches/DBCP_1_5_x_BRANCH/src/main/java/org/apache/commons/dbcp/PoolableConnection.java

Modified: commons/proper/dbcp/branches/DBCP_1_5_x_BRANCH/src/changes/changes.xml
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/branches/DBCP_1_5_x_BRANCH/src/changes/changes.xml?rev=1564068&r1=1564067&r2=1564068&view=diff
==============================================================================
--- commons/proper/dbcp/branches/DBCP_1_5_x_BRANCH/src/changes/changes.xml (original)
+++ commons/proper/dbcp/branches/DBCP_1_5_x_BRANCH/src/changes/changes.xml Mon Feb  3 21:25:39 2014
@@ -91,6 +91,9 @@ The <action> type attribute can be add,u
         Ensure that the XAConnection is closed when the associated Connection is
         closed.
       </action>
+      <action dev="markt" issue="DBCP-398" type="fix">
+        Clarify Jaavdoc for isClosed() method of PoolableConnection.
+      </action>
     </release>
     <release version="1.4.1" date="TBD" description="TBD">
       <action dev="psteitz" issue="DBCP-367" type="fix" due-to="Ken Tatsushita">

Modified: commons/proper/dbcp/branches/DBCP_1_5_x_BRANCH/src/main/java/org/apache/commons/dbcp/PoolableConnection.java
URL: http://svn.apache.org/viewvc/commons/proper/dbcp/branches/DBCP_1_5_x_BRANCH/src/main/java/org/apache/commons/dbcp/PoolableConnection.java?rev=1564068&r1=1564067&r2=1564068&view=diff
==============================================================================
--- commons/proper/dbcp/branches/DBCP_1_5_x_BRANCH/src/main/java/org/apache/commons/dbcp/PoolableConnection.java (original)
+++ commons/proper/dbcp/branches/DBCP_1_5_x_BRANCH/src/main/java/org/apache/commons/dbcp/PoolableConnection.java Mon Feb  3 21:25:39 2014
@@ -58,6 +58,14 @@ public class PoolableConnection extends 
     }
 
 
+    /**
+     * {@inheritDoc}
+     * <p>
+     * This method should not be used by a client to determine whether or not a
+     * connection should be return to the connection pool (by calling
+     * {@link #close()}). Clients should always attempt to return a connection
+     * to the pool once it is no longer required.
+     */
     @Override
     public boolean isClosed() throws SQLException {
         if (_closed) {