You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/08/06 16:01:51 UTC
[GitHub] [incubator-uniffle] smallzhongfeng opened a new pull request, #139: [Improvement] Add timeout reconnection when DelegationRssShuffleManager send the request of AccessCluster
smallzhongfeng opened a new pull request, #139:
URL: https://github.com/apache/incubator-uniffle/pull/139
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://github.com/Tencent/Firestorm/blob/master/CONTRIBUTING.md
2. Ensure you have added or run the appropriate tests for your PR
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]XXXX Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
To solve issue [#127](https://github.com/apache/incubator-uniffle/issues/127)
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
Avoid some memory shortage situations, and retry to ensure that the tasks run in the RSS cluster as much as possible.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
No need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #139: [Improvement] Add timeout reconnection when DelegationRssShuffleManager send the request of AccessCluster
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #139:
URL: https://github.com/apache/incubator-uniffle/pull/139#issuecomment-1207325254
> ### Does this PR introduce _any_ user-facing change?
> No.
>
This is a user-facing change. It add some config options, you should add some documents to explain how to use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #139: [Improvement] Add timeout reconnection when DelegationRssShuffleManager send the request of AccessCluster
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #139:
URL: https://github.com/apache/incubator-uniffle/pull/139#issuecomment-1207356480
Could we add some test cases for this pr? Could you add documents in https://github.com/apache/incubator-uniffle/blob/master/docs/client_guide.md?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #139: [Improvement] Add timeout reconnection when DelegationRssShuffleManager send the request of AccessCluster
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #139:
URL: https://github.com/apache/incubator-uniffle/pull/139#discussion_r939602307
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java:
##########
@@ -214,7 +214,17 @@ public class RssSparkConfig {
public static final ConfigEntry<Integer> RSS_CLIENT_ASSIGNMENT_RETRY_TIMES = createIntegerBuilder(
new ConfigBuilder(SPARK_RSS_CONFIG_PREFIX + RssClientConfig.RSS_CLIENT_ASSIGNMENT_RETRY_TIMES))
.createWithDefault(RssClientConfig.RSS_CLIENT_ASSIGNMENT_RETRY_TIMES_DEFAULT_VALUE);
-
+
+ public static final ConfigEntry<Long> RSS_CLIENT_FALLBACK_RETRY_INTERVAL = createLongBuilder(
Review Comment:
Could we use`spark.rss.client.access.retry.interval.ms`? Because we want to access RSS instead of fallback, the variable's name contains unit, it will improve readability.
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java:
##########
@@ -214,7 +214,17 @@ public class RssSparkConfig {
public static final ConfigEntry<Integer> RSS_CLIENT_ASSIGNMENT_RETRY_TIMES = createIntegerBuilder(
new ConfigBuilder(SPARK_RSS_CONFIG_PREFIX + RssClientConfig.RSS_CLIENT_ASSIGNMENT_RETRY_TIMES))
.createWithDefault(RssClientConfig.RSS_CLIENT_ASSIGNMENT_RETRY_TIMES_DEFAULT_VALUE);
-
+
+ public static final ConfigEntry<Long> RSS_CLIENT_FALLBACK_RETRY_INTERVAL = createLongBuilder(
+ new ConfigBuilder("spark.rss.client.fallback.retry.interval")
+ .doc("Interval between retries fallback to SortShuffleManager"))
+ .createWithDefault(20000L);
+
+ public static final ConfigEntry<Integer> RSS_CLIENT_FALLBACK_RETRY_TIMES = createIntegerBuilder(
+ new ConfigBuilder("spark.rss.client.fallback.retry.times")
+ .doc("Number of retries fallback to SortShuffleManager"))
+ .createWithDefault(3);
Review Comment:
Could we use default value `0`? Because we want to keep consistent with the previous behaviour.
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java:
##########
@@ -214,7 +214,17 @@ public class RssSparkConfig {
public static final ConfigEntry<Integer> RSS_CLIENT_ASSIGNMENT_RETRY_TIMES = createIntegerBuilder(
new ConfigBuilder(SPARK_RSS_CONFIG_PREFIX + RssClientConfig.RSS_CLIENT_ASSIGNMENT_RETRY_TIMES))
.createWithDefault(RssClientConfig.RSS_CLIENT_ASSIGNMENT_RETRY_TIMES_DEFAULT_VALUE);
-
+
+ public static final ConfigEntry<Long> RSS_CLIENT_FALLBACK_RETRY_INTERVAL = createLongBuilder(
+ new ConfigBuilder("spark.rss.client.fallback.retry.interval")
+ .doc("Interval between retries fallback to SortShuffleManager"))
+ .createWithDefault(20000L);
+
+ public static final ConfigEntry<Integer> RSS_CLIENT_FALLBACK_RETRY_TIMES = createIntegerBuilder(
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #139: [Improvement] Add timeout reconnection when DelegationRssShuffleManager send the request of AccessCluster
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #139:
URL: https://github.com/apache/incubator-uniffle/pull/139#discussion_r939627526
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java:
##########
@@ -214,7 +214,17 @@ public class RssSparkConfig {
public static final ConfigEntry<Integer> RSS_CLIENT_ASSIGNMENT_RETRY_TIMES = createIntegerBuilder(
new ConfigBuilder(SPARK_RSS_CONFIG_PREFIX + RssClientConfig.RSS_CLIENT_ASSIGNMENT_RETRY_TIMES))
.createWithDefault(RssClientConfig.RSS_CLIENT_ASSIGNMENT_RETRY_TIMES_DEFAULT_VALUE);
-
+
+ public static final ConfigEntry<Long> RSS_CLIENT_FALLBACK_RETRY_INTERVAL = createLongBuilder(
+ new ConfigBuilder("spark.rss.client.access.retry.interval.ms")
+ .doc("Interval between retries fallback to SortShuffleManager"))
+ .createWithDefault(20000L);
+
+ public static final ConfigEntry<Integer> RSS_CLIENT_FALLBACK_RETRY_TIMES = createIntegerBuilder(
+ new ConfigBuilder("spark.rss.client.access.retry.times")
Review Comment:
Could we change `RSS_CLIENT_FALLBACK_RETRY_TIMES` to `RSS_CLIENT_ACCESS_RETRY_TIMES` together?
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java:
##########
@@ -214,7 +214,17 @@ public class RssSparkConfig {
public static final ConfigEntry<Integer> RSS_CLIENT_ASSIGNMENT_RETRY_TIMES = createIntegerBuilder(
new ConfigBuilder(SPARK_RSS_CONFIG_PREFIX + RssClientConfig.RSS_CLIENT_ASSIGNMENT_RETRY_TIMES))
.createWithDefault(RssClientConfig.RSS_CLIENT_ASSIGNMENT_RETRY_TIMES_DEFAULT_VALUE);
-
+
+ public static final ConfigEntry<Long> RSS_CLIENT_FALLBACK_RETRY_INTERVAL = createLongBuilder(
Review Comment:
Could we change `RSS_CLIENT_FALLBACK_RETRY_INTERVAL` to `RSS_CLIENT_ACCESS_RETRY_INTERVAL_MS` together?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on a diff in pull request #139: [Improvement] Add timeout reconnection when DelegationRssShuffleManager send the request of AccessCluster
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on code in PR #139:
URL: https://github.com/apache/incubator-uniffle/pull/139#discussion_r939622580
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java:
##########
@@ -214,7 +214,17 @@ public class RssSparkConfig {
public static final ConfigEntry<Integer> RSS_CLIENT_ASSIGNMENT_RETRY_TIMES = createIntegerBuilder(
new ConfigBuilder(SPARK_RSS_CONFIG_PREFIX + RssClientConfig.RSS_CLIENT_ASSIGNMENT_RETRY_TIMES))
.createWithDefault(RssClientConfig.RSS_CLIENT_ASSIGNMENT_RETRY_TIMES_DEFAULT_VALUE);
-
+
+ public static final ConfigEntry<Long> RSS_CLIENT_FALLBACK_RETRY_INTERVAL = createLongBuilder(
+ new ConfigBuilder("spark.rss.client.fallback.retry.interval")
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on a diff in pull request #139: [Improvement] Add timeout reconnection when DelegationRssShuffleManager send the request of AccessCluster
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on code in PR #139:
URL: https://github.com/apache/incubator-uniffle/pull/139#discussion_r939695510
##########
client-spark/spark3/src/test/java/org/apache/spark/shuffle/DelegationRssShuffleManagerTest.java:
##########
@@ -135,6 +137,31 @@ public void testCreateFallback() throws Exception {
assertTrue(hasException);
}
+ @Test
+ public void testTryAccessCluster() {
+ SparkConf conf = new SparkConf();
Review Comment:
I don't think so, because `tryAccessCluster` is not directly called by the `CoordinatorClient`, and the `tryAccessCluster`method depends on the list of global object `coordinatorClients`, so I don't have a better way for the time being.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on a diff in pull request #139: [Improvement] Add timeout reconnection when DelegationRssShuffleManager send the request of AccessCluster
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on code in PR #139:
URL: https://github.com/apache/incubator-uniffle/pull/139#discussion_r939622580
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java:
##########
@@ -214,7 +214,17 @@ public class RssSparkConfig {
public static final ConfigEntry<Integer> RSS_CLIENT_ASSIGNMENT_RETRY_TIMES = createIntegerBuilder(
new ConfigBuilder(SPARK_RSS_CONFIG_PREFIX + RssClientConfig.RSS_CLIENT_ASSIGNMENT_RETRY_TIMES))
.createWithDefault(RssClientConfig.RSS_CLIENT_ASSIGNMENT_RETRY_TIMES_DEFAULT_VALUE);
-
+
+ public static final ConfigEntry<Long> RSS_CLIENT_FALLBACK_RETRY_INTERVAL = createLongBuilder(
+ new ConfigBuilder("spark.rss.client.fallback.retry.interval")
Review Comment:
Got it.
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java:
##########
@@ -214,7 +214,17 @@ public class RssSparkConfig {
public static final ConfigEntry<Integer> RSS_CLIENT_ASSIGNMENT_RETRY_TIMES = createIntegerBuilder(
new ConfigBuilder(SPARK_RSS_CONFIG_PREFIX + RssClientConfig.RSS_CLIENT_ASSIGNMENT_RETRY_TIMES))
.createWithDefault(RssClientConfig.RSS_CLIENT_ASSIGNMENT_RETRY_TIMES_DEFAULT_VALUE);
-
+
+ public static final ConfigEntry<Long> RSS_CLIENT_FALLBACK_RETRY_INTERVAL = createLongBuilder(
+ new ConfigBuilder("spark.rss.client.fallback.retry.interval")
+ .doc("Interval between retries fallback to SortShuffleManager"))
+ .createWithDefault(20000L);
+
+ public static final ConfigEntry<Integer> RSS_CLIENT_FALLBACK_RETRY_TIMES = createIntegerBuilder(
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on a diff in pull request #139: [Improvement] Add timeout reconnection when DelegationRssShuffleManager send the request of AccessCluster
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on code in PR #139:
URL: https://github.com/apache/incubator-uniffle/pull/139#discussion_r939809771
##########
client-spark/spark3/src/test/java/org/apache/spark/shuffle/DelegationRssShuffleManagerTest.java:
##########
@@ -135,6 +137,27 @@ public void testCreateFallback() throws Exception {
assertTrue(hasException);
}
+ @Test
+ public void testTryAccessCluster() throws Exception {
+ CoordinatorClient mockDeniedCoordinatorClient = mock(CoordinatorClient.class);
+ when(mockDeniedCoordinatorClient.accessCluster(any()))
+ .thenReturn(new RssAccessClusterResponse(ACCESS_DENIED, ""))
+ .thenReturn(new RssAccessClusterResponse(ACCESS_DENIED, ""))
+ .thenReturn(new RssAccessClusterResponse(SUCCESS, ""));
+ List<CoordinatorClient> coordinatorClients = Lists.newArrayList();
+ coordinatorClients.add(mockDeniedCoordinatorClient);
+ mockedStaticRssShuffleUtils.when(() ->
+ RssSparkShuffleUtils.createCoordinatorClients(any())).thenReturn(coordinatorClients);
+ SparkConf conf = new SparkConf();
+ conf.set(RssSparkConfig.RSS_CLIENT_ACCESS_RETRY_INTERVAL_MS, 3000L);
+ conf.set(RssSparkConfig.RSS_CLIENT_ACCESS_RETRY_TIMES, 3);
+ conf.set(RssSparkConfig.RSS_DYNAMIC_CLIENT_CONF_ENABLED.key(), "false");
+ conf.set(RssSparkConfig.RSS_ACCESS_ID.key(), "mockId");
+ conf.set(RssSparkConfig.RSS_COORDINATOR_QUORUM.key(), "m1:8001,m2:8002");
+ conf.set("spark.rss.storage.type", StorageType.LOCALFILE.name());
+ assertCreateRssShuffleManager(conf);
Review Comment:
Added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on pull request #139: [Improvement] Add timeout reconnection when DelegationRssShuffleManager send the request of AccessCluster
Posted by GitBox <gi...@apache.org>.
jerqi commented on PR #139:
URL: https://github.com/apache/incubator-uniffle/pull/139#issuecomment-1207366307
> > Could we add some test cases for this pr? Could you add documents in https://github.com/apache/incubator-uniffle/blob/master/docs/client_guide.md?
>
> I think this PR has more logic of retry, and I think it is enough to have the test class RetryUtilsTest, or do you have any better suggestions?
Could we add a test case in DelegationRssShuffleManagerTest? If you change the logic, we'd better have test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #139: [Improvement] Add timeout reconnection when DelegationRssShuffleManager send the request of AccessCluster
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #139:
URL: https://github.com/apache/incubator-uniffle/pull/139#discussion_r939799293
##########
client-spark/spark3/src/test/java/org/apache/spark/shuffle/DelegationRssShuffleManagerTest.java:
##########
@@ -135,6 +137,27 @@ public void testCreateFallback() throws Exception {
assertTrue(hasException);
}
+ @Test
+ public void testTryAccessCluster() throws Exception {
+ CoordinatorClient mockDeniedCoordinatorClient = mock(CoordinatorClient.class);
+ when(mockDeniedCoordinatorClient.accessCluster(any()))
+ .thenReturn(new RssAccessClusterResponse(ACCESS_DENIED, ""))
+ .thenReturn(new RssAccessClusterResponse(ACCESS_DENIED, ""))
+ .thenReturn(new RssAccessClusterResponse(SUCCESS, ""));
+ List<CoordinatorClient> coordinatorClients = Lists.newArrayList();
+ coordinatorClients.add(mockDeniedCoordinatorClient);
+ mockedStaticRssShuffleUtils.when(() ->
+ RssSparkShuffleUtils.createCoordinatorClients(any())).thenReturn(coordinatorClients);
+ SparkConf conf = new SparkConf();
+ conf.set(RssSparkConfig.RSS_CLIENT_ACCESS_RETRY_INTERVAL_MS, 3000L);
+ conf.set(RssSparkConfig.RSS_CLIENT_ACCESS_RETRY_TIMES, 3);
+ conf.set(RssSparkConfig.RSS_DYNAMIC_CLIENT_CONF_ENABLED.key(), "false");
+ conf.set(RssSparkConfig.RSS_ACCESS_ID.key(), "mockId");
+ conf.set(RssSparkConfig.RSS_COORDINATOR_QUORUM.key(), "m1:8001,m2:8002");
+ conf.set("spark.rss.storage.type", StorageType.LOCALFILE.name());
+ assertCreateRssShuffleManager(conf);
Review Comment:
Could we add a case that the the access fail 4 times and we need to create sort shuffle manager?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on a diff in pull request #139: [Improvement] Add timeout reconnection when DelegationRssShuffleManager send the request of AccessCluster
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on code in PR #139:
URL: https://github.com/apache/incubator-uniffle/pull/139#discussion_r939623299
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java:
##########
@@ -214,7 +214,17 @@ public class RssSparkConfig {
public static final ConfigEntry<Integer> RSS_CLIENT_ASSIGNMENT_RETRY_TIMES = createIntegerBuilder(
new ConfigBuilder(SPARK_RSS_CONFIG_PREFIX + RssClientConfig.RSS_CLIENT_ASSIGNMENT_RETRY_TIMES))
.createWithDefault(RssClientConfig.RSS_CLIENT_ASSIGNMENT_RETRY_TIMES_DEFAULT_VALUE);
-
+
+ public static final ConfigEntry<Long> RSS_CLIENT_FALLBACK_RETRY_INTERVAL = createLongBuilder(
+ new ConfigBuilder("spark.rss.client.fallback.retry.interval")
+ .doc("Interval between retries fallback to SortShuffleManager"))
+ .createWithDefault(20000L);
+
+ public static final ConfigEntry<Integer> RSS_CLIENT_FALLBACK_RETRY_TIMES = createIntegerBuilder(
+ new ConfigBuilder("spark.rss.client.fallback.retry.times")
+ .doc("Number of retries fallback to SortShuffleManager"))
+ .createWithDefault(3);
Review Comment:
Agree with you, users can change it on their own if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #139: [Improvement] Add timeout reconnection when DelegationRssShuffleManager send the request of AccessCluster
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #139:
URL: https://github.com/apache/incubator-uniffle/pull/139#discussion_r939682796
##########
client-spark/spark3/src/test/java/org/apache/spark/shuffle/DelegationRssShuffleManagerTest.java:
##########
@@ -135,6 +137,31 @@ public void testCreateFallback() throws Exception {
assertTrue(hasException);
}
+ @Test
+ public void testTryAccessCluster() {
+ SparkConf conf = new SparkConf();
Review Comment:
Could we mock coordinator client? Could we use the method `tryAccessCluster` in this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on a diff in pull request #139: [Improvement] Add timeout reconnection when DelegationRssShuffleManager send the request of AccessCluster
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on code in PR #139:
URL: https://github.com/apache/incubator-uniffle/pull/139#discussion_r939695510
##########
client-spark/spark3/src/test/java/org/apache/spark/shuffle/DelegationRssShuffleManagerTest.java:
##########
@@ -135,6 +137,31 @@ public void testCreateFallback() throws Exception {
assertTrue(hasException);
}
+ @Test
+ public void testTryAccessCluster() {
+ SparkConf conf = new SparkConf();
Review Comment:
I thought so at first, but `tryAccessCluster` is not directly called by the `CoordinatorClient`, and the `tryAccessCluster`method depends on the list of global object `coordinatorClients`, so I don't have a better way for the time being.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on a diff in pull request #139: [Improvement] Add timeout reconnection when DelegationRssShuffleManager send the request of AccessCluster
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on code in PR #139:
URL: https://github.com/apache/incubator-uniffle/pull/139#discussion_r939797737
##########
client-spark/spark3/src/test/java/org/apache/spark/shuffle/DelegationRssShuffleManagerTest.java:
##########
@@ -135,6 +137,31 @@ public void testCreateFallback() throws Exception {
assertTrue(hasException);
}
+ @Test
+ public void testTryAccessCluster() {
+ SparkConf conf = new SparkConf();
Review Comment:
Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on pull request #139: [Improvement] Add timeout reconnection when DelegationRssShuffleManager send the request of AccessCluster
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on PR #139:
URL: https://github.com/apache/incubator-uniffle/pull/139#issuecomment-1207365300
> Could we add some test cases for this pr? Could you add documents in https://github.com/apache/incubator-uniffle/blob/master/docs/client_guide.md?
I think this PR has more logic of retry, and I think it is enough to have the test class RetryUtilsTest, or do you have any better suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi merged pull request #139: [Improvement] Add timeout reconnection when DelegationRssShuffleManager send the request of AccessCluster
Posted by GitBox <gi...@apache.org>.
jerqi merged PR #139:
URL: https://github.com/apache/incubator-uniffle/pull/139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on a diff in pull request #139: [Improvement] Add timeout reconnection when DelegationRssShuffleManager send the request of AccessCluster
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on code in PR #139:
URL: https://github.com/apache/incubator-uniffle/pull/139#discussion_r939622871
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java:
##########
@@ -214,7 +214,17 @@ public class RssSparkConfig {
public static final ConfigEntry<Integer> RSS_CLIENT_ASSIGNMENT_RETRY_TIMES = createIntegerBuilder(
new ConfigBuilder(SPARK_RSS_CONFIG_PREFIX + RssClientConfig.RSS_CLIENT_ASSIGNMENT_RETRY_TIMES))
.createWithDefault(RssClientConfig.RSS_CLIENT_ASSIGNMENT_RETRY_TIMES_DEFAULT_VALUE);
-
+
+ public static final ConfigEntry<Long> RSS_CLIENT_FALLBACK_RETRY_INTERVAL = createLongBuilder(
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on a diff in pull request #139: [Improvement] Add timeout reconnection when DelegationRssShuffleManager send the request of AccessCluster
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on code in PR #139:
URL: https://github.com/apache/incubator-uniffle/pull/139#discussion_r939635304
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java:
##########
@@ -214,7 +214,17 @@ public class RssSparkConfig {
public static final ConfigEntry<Integer> RSS_CLIENT_ASSIGNMENT_RETRY_TIMES = createIntegerBuilder(
new ConfigBuilder(SPARK_RSS_CONFIG_PREFIX + RssClientConfig.RSS_CLIENT_ASSIGNMENT_RETRY_TIMES))
.createWithDefault(RssClientConfig.RSS_CLIENT_ASSIGNMENT_RETRY_TIMES_DEFAULT_VALUE);
-
+
+ public static final ConfigEntry<Long> RSS_CLIENT_FALLBACK_RETRY_INTERVAL = createLongBuilder(
+ new ConfigBuilder("spark.rss.client.access.retry.interval.ms")
+ .doc("Interval between retries fallback to SortShuffleManager"))
+ .createWithDefault(20000L);
+
+ public static final ConfigEntry<Integer> RSS_CLIENT_FALLBACK_RETRY_TIMES = createIntegerBuilder(
+ new ConfigBuilder("spark.rss.client.access.retry.times")
Review Comment:
I forgot to change it. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on pull request #139: [Improvement] Add timeout reconnection when DelegationRssShuffleManager send the request of AccessCluster
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on PR #139:
URL: https://github.com/apache/incubator-uniffle/pull/139#issuecomment-1207424326
> > > Could we add some test cases for this pr? Could you add documents in https://github.com/apache/incubator-uniffle/blob/master/docs/client_guide.md?
> >
> >
> > I think this PR has more logic of retry, and I think it is enough to have the test class RetryUtilsTest, or do you have any better suggestions?
>
> Could we add a test case in DelegationRssShuffleManagerTest? If you change the logic, we'd better have test case.
I added a simple test. Do you have a good idea?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on a diff in pull request #139: [Improvement] Add timeout reconnection when DelegationRssShuffleManager send the request of AccessCluster
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on code in PR #139:
URL: https://github.com/apache/incubator-uniffle/pull/139#discussion_r939695510
##########
client-spark/spark3/src/test/java/org/apache/spark/shuffle/DelegationRssShuffleManagerTest.java:
##########
@@ -135,6 +137,31 @@ public void testCreateFallback() throws Exception {
assertTrue(hasException);
}
+ @Test
+ public void testTryAccessCluster() {
+ SparkConf conf = new SparkConf();
Review Comment:
I don't think so, because `tryAccessCluster` is not directly called by the `CoordinatorClient`, and the `tryAccessCluster`method depends on the list of global object `CoordinatorClient`, so I don't have a better way for the time being.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #139: [Improvement] Add timeout reconnection when DelegationRssShuffleManager send the request of AccessCluster
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #139:
URL: https://github.com/apache/incubator-uniffle/pull/139#discussion_r939601882
##########
client-spark/common/src/main/java/org/apache/spark/shuffle/RssSparkConfig.java:
##########
@@ -214,7 +214,17 @@ public class RssSparkConfig {
public static final ConfigEntry<Integer> RSS_CLIENT_ASSIGNMENT_RETRY_TIMES = createIntegerBuilder(
new ConfigBuilder(SPARK_RSS_CONFIG_PREFIX + RssClientConfig.RSS_CLIENT_ASSIGNMENT_RETRY_TIMES))
.createWithDefault(RssClientConfig.RSS_CLIENT_ASSIGNMENT_RETRY_TIMES_DEFAULT_VALUE);
-
+
+ public static final ConfigEntry<Long> RSS_CLIENT_FALLBACK_RETRY_INTERVAL = createLongBuilder(
+ new ConfigBuilder("spark.rss.client.fallback.retry.interval")
Review Comment:
Could we use `spark.rss.client.access.retry.interval.ms`? Because we don't attempt to fallback, we want to access RSS.The variable's name should have unit, it improves readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] smallzhongfeng commented on pull request #139: [Improvement] Add timeout reconnection when DelegationRssShuffleManager send the request of AccessCluster
Posted by GitBox <gi...@apache.org>.
smallzhongfeng commented on PR #139:
URL: https://github.com/apache/incubator-uniffle/pull/139#issuecomment-1207350406
> > ### Does this PR introduce _any_ user-facing change?
> > No.
>
> This is a user-facing change. It add some config options, you should add some documents to explain how to use it.
Added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #139: [Improvement] Add timeout reconnection when DelegationRssShuffleManager send the request of AccessCluster
Posted by GitBox <gi...@apache.org>.
jerqi commented on code in PR #139:
URL: https://github.com/apache/incubator-uniffle/pull/139#discussion_r939771045
##########
client-spark/spark3/src/test/java/org/apache/spark/shuffle/DelegationRssShuffleManagerTest.java:
##########
@@ -135,6 +137,31 @@ public void testCreateFallback() throws Exception {
assertTrue(hasException);
}
+ @Test
+ public void testTryAccessCluster() {
+ SparkConf conf = new SparkConf();
Review Comment:
`coordinatorClients` is created by `RssSparkShuffleUtils.createCoordinatorClients(sparkConf)`. Could we imitate https://github.com/apache/incubator-uniffle/blob/79804c544b560ae3e872964a428d328dd71489a7/client-spark/spark2/src/test/java/org/apache/spark/shuffle/DelegationRssShuffleManagerTest.java#L79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #139: [Improvement] Add timeout reconnection when DelegationRssShuffleManager send the request of AccessCluster
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #139:
URL: https://github.com/apache/incubator-uniffle/pull/139#issuecomment-1207241617
# [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/139?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#139](https://codecov.io/gh/apache/incubator-uniffle/pull/139?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b2aa545) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/79804c544b560ae3e872964a428d328dd71489a7?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (79804c5) will **decrease** coverage by `1.43%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #139 +/- ##
============================================
- Coverage 57.18% 55.74% -1.44%
+ Complexity 1201 1122 -79
============================================
Files 150 141 -9
Lines 8179 7688 -491
Branches 773 742 -31
============================================
- Hits 4677 4286 -391
+ Misses 3256 3166 -90
+ Partials 246 236 -10
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-uniffle/pull/139?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...storage/handler/impl/DataSkippableReadHandler.java](https://codecov.io/gh/apache/incubator-uniffle/pull/139/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3RvcmFnZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdW5pZmZsZS9zdG9yYWdlL2hhbmRsZXIvaW1wbC9EYXRhU2tpcHBhYmxlUmVhZEhhbmRsZXIuamF2YQ==) | `81.25% <0.00%> (-3.13%)` | :arrow_down: |
| [...org/apache/uniffle/server/ShuffleFlushManager.java](https://codecov.io/gh/apache/incubator-uniffle/pull/139/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS91bmlmZmxlL3NlcnZlci9TaHVmZmxlRmx1c2hNYW5hZ2VyLmphdmE=) | `76.83% <0.00%> (-1.70%)` | :arrow_down: |
| [.../java/org/apache/spark/shuffle/RssSparkConfig.java](https://codecov.io/gh/apache/incubator-uniffle/pull/139/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS9Sc3NTcGFya0NvbmZpZy5qYXZh) | | |
| [...e/spark/shuffle/reader/RssShuffleDataIterator.java](https://codecov.io/gh/apache/incubator-uniffle/pull/139/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS9yZWFkZXIvUnNzU2h1ZmZsZURhdGFJdGVyYXRvci5qYXZh) | | |
| [...che/spark/shuffle/writer/BufferManagerOptions.java](https://codecov.io/gh/apache/incubator-uniffle/pull/139/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS93cml0ZXIvQnVmZmVyTWFuYWdlck9wdGlvbnMuamF2YQ==) | | |
| [...pache/spark/shuffle/writer/WriteBufferManager.java](https://codecov.io/gh/apache/incubator-uniffle/pull/139/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS93cml0ZXIvV3JpdGVCdWZmZXJNYW5hZ2VyLmphdmE=) | | |
| [...ava/org/apache/spark/shuffle/RssShuffleHandle.java](https://codecov.io/gh/apache/incubator-uniffle/pull/139/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS9Sc3NTaHVmZmxlSGFuZGxlLmphdmE=) | | |
| [.../org/apache/spark/shuffle/writer/WriterBuffer.java](https://codecov.io/gh/apache/incubator-uniffle/pull/139/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS93cml0ZXIvV3JpdGVyQnVmZmVyLmphdmE=) | | |
| [...org/apache/spark/shuffle/RssSparkShuffleUtils.java](https://codecov.io/gh/apache/incubator-uniffle/pull/139/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS9Sc3NTcGFya1NodWZmbGVVdGlscy5qYXZh) | | |
| [...org/apache/spark/shuffle/writer/AddBlockEvent.java](https://codecov.io/gh/apache/incubator-uniffle/pull/139/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50LXNwYXJrL2NvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc3Bhcmsvc2h1ZmZsZS93cml0ZXIvQWRkQmxvY2tFdmVudC5qYXZh) | | |
| ... and [1 more](https://codecov.io/gh/apache/incubator-uniffle/pull/139/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org