You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "tvalentyn (via GitHub)" <gi...@apache.org> on 2023/05/18 22:59:57 UTC
[GitHub] [beam] tvalentyn opened a new pull request, #26777: Match catch clause in the codepath that reports the error to the worker to a clause that marks the bundle as failed.
tvalentyn opened a new pull request, #26777:
URL: https://github.com/apache/beam/pull/26777
If user code raises a BaseException during processing, bundle will be marked as failed by the SDK but will not be reported as failed to the worker harness. To fix this, match the error handling catch clause in the outer method to the error handling close where bundle is marked failed: https://github.com/apache/beam/blob/dbefe4f8b0915d4d1bd83f315705efaf0b526d3d/sdks/python/apache_beam/runners/worker/sdk_worker.py#L683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn merged pull request #26777: Match catch clause in the codepath that reports the error to the worker to a clause that marks the bundle as failed.
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn merged PR #26777:
URL: https://github.com/apache/beam/pull/26777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #26777: Match catch clause in the codepath that reports the error to the worker to a clause that marks the bundle as failed.
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #26777:
URL: https://github.com/apache/beam/pull/26777#issuecomment-1553797415
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/26777?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#26777](https://app.codecov.io/gh/apache/beam/pull/26777?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ca2a267) into [master](https://app.codecov.io/gh/apache/beam/commit/dbefe4f8b0915d4d1bd83f315705efaf0b526d3d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (dbefe4f) will **decrease** coverage by `0.08%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #26777 +/- ##
==========================================
- Coverage 72.05% 71.97% -0.08%
==========================================
Files 745 747 +2
Lines 101203 101306 +103
==========================================
- Hits 72920 72916 -4
- Misses 26824 26931 +107
Partials 1459 1459
```
| Flag | Coverage Δ | |
|---|---|---|
| python | `80.95% <100.00%> (-0.13%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/beam/pull/26777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://app.codecov.io/gh/apache/beam/pull/26777?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==) | `89.20% <100.00%> (ø)` | |
... and [11 files with indirect coverage changes](https://app.codecov.io/gh/apache/beam/pull/26777/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26777: Match catch clause in the codepath that reports the error to the worker to a clause that marks the bundle as failed.
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26777:
URL: https://github.com/apache/beam/pull/26777#issuecomment-1553761055
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #26777: Match catch clause in the codepath that reports the error to the worker to a clause that marks the bundle as failed.
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #26777:
URL: https://github.com/apache/beam/pull/26777#issuecomment-1553766543
Run Python_Dataframes PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] tvalentyn commented on pull request #26777: Match catch clause in the codepath that reports the error to the worker to a clause that marks the bundle as failed.
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on PR #26777:
URL: https://github.com/apache/beam/pull/26777#issuecomment-1553760213
R: @robertwb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org