[GitHub] [qpid-proton] jiridanek commented on a change in pull request #156: PROTON-1936: lower case include and updated ifdefs

[GitBox <gi...@apache.org>]

jiridanek commented on a change in pull request #156: PROTON-1936: lower case include and updated ifdefs
URL: https://github.com/apache/qpid-proton/pull/156#discussion_r407172209
 
 

 ##########
 File path: c/src/platform/platform.h
 ##########
 @@ -81,7 +81,7 @@ int pni_vsnprintf(char *buf, size_t count, const char *fmt, va_list ap);
 
 #endif
 
-#if defined _MSC_VER || defined _OPENVMS
+#if defined _MSC_VER || defined(_WIN32) || defined _OPENVMS
 
 Review comment:
   I am surprised this is needed. I always believed mingw is a version of GCC, and therefore there wouldn't be a version of mingw that does not define the va_copy macro.
   
   It would be nice to switch to Visual Studio 2015+, and stop supporting 2013. Then there would be va_copy always defined even on MSVC.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org