[GitHub] [iceberg] kbendick commented on pull request #5009: [WIP][CORE] - Fix snapshot summary generating partition summary metrics for unpartitioned tables

[GitBox <gi...@apache.org>]

kbendick commented on PR #5009:
URL: https://github.com/apache/iceberg/pull/5009#issuecomment-1151566616

   After this change, here's the actual summary (from the test) for both the unpartitioned table and the partitioned table. I also tested this with Spark (and have a unit test for it but felt it was not necessary for CI).
   
   Unpartitioned
   ```json
   {
     "added-data-files": "1",
     "added-records": "10",
     "added-files-size": "350",
     "changed-partition-count": "0",
     "total-records": "10",
     "total-files-size": "350",
     "total-data-files": "1",
     "total-delete-files": "0",
     "total-position-deletes": "0",
     "total-equality-deletes": "0"
   }
   ```
   
   Partitioned
   ```json
   {
     "added-data-files": "1",
     "added-records": "10",
     "added-files-size": "350",
     "changed-partition-count": "1",
     "partition-summaries-included": "true",
     "partitions.data_bucket=0": "added-data-files=1,added-records=10,added-files-size=350",
     "total-records": "10",
     "total-files-size": "350",
     "total-data-files": "1",
     "total-delete-files": "0",
     "total-position-deletes": "0",
     "total-equality-deletes": "0"
   }
   ````


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org