[GitHub] [spark] Ngone51 commented on a change in pull request #27539: [SPARK-30786] [BLOCK MANAGER] Fix Block replication failure propogation issue in BlockManager

[GitBox <gi...@apache.org>]

Ngone51 commented on a change in pull request #27539: [SPARK-30786] [BLOCK MANAGER] Fix Block replication failure propogation issue in BlockManager
URL: https://github.com/apache/spark/pull/27539#discussion_r377512390
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/network/netty/NettyBlockRpcServer.scala
 ##########
 @@ -105,7 +105,11 @@ class NettyBlockRpcServer(
         val blockId = BlockId(uploadBlock.blockId)
         logDebug(s"Receiving replicated block $blockId with level ${level} " +
           s"from ${client.getSocketAddress}")
-        blockManager.putBlockData(blockId, data, level, classTag)
+        val blockStored = blockManager.putBlockData(blockId, data, level, classTag)
+        if (!blockStored) {
+          throw new Exception(s"Upload block for $blockId failed. This " +
+            s"mostly happens when there is not sufficient space available to store the block.")
+        }
 
 Review comment:
   How about replying the client with `responseContext.ononFailure(e)` since this is a controlled exception? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org