You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/04/05 04:15:44 UTC

[GitHub] mistercrunch commented on a change in pull request #4746: Filtering out SQLLab views out of table list view by default

mistercrunch commented on a change in pull request #4746: Filtering out SQLLab views out of table list view by default
URL: https://github.com/apache/incubator-superset/pull/4746#discussion_r179346093
 
 

 ##########
 File path: superset/connectors/sqla/views.py
 ##########
 @@ -213,8 +216,10 @@ class TableModelView(DatasourceModelView, DeleteMixin, YamlExportMixin):  # noqa
             "Whether to populate the filter's dropdown in the explore "
             "view's filter section with a list of distinct values fetched "
             'from the backend on the fly'),
+        'is_sqllab_view': _(
 
 Review comment:
   I could remove it from the `edit_columns` and have it only in the `show_columns` if you think it's better

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services