[GitHub] mistercrunch closed pull request #5258: Issue #4983 - sqllab executed sql without response.

[GitBox <gi...@apache.org>]

mistercrunch closed pull request #5258: Issue #4983 - sqllab executed sql without response.
URL: https://github.com/apache/incubator-superset/pull/5258
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/views/core.py b/superset/views/core.py
index d290ecc9ca..8f507f8970 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -2450,13 +2450,13 @@ def sql_json(self):
             timeout_msg = (
                 'The query exceeded the {timeout} seconds '
                 'timeout.').format(**locals())
-            with utils.timeout(seconds=timeout,
-                               error_message=timeout_msg):
-                # pylint: disable=no-value-for-parameter
-                data = sql_lab.get_sql_results(
-                    query_id,
-                    rendered_query,
-                    return_results=True)
+            # with utils.timeout(seconds=timeout,
+            #                    error_message=timeout_msg):
+            # pylint: disable=no-value-for-parameter
+            data = sql_lab.get_sql_results(
+                query_id,
+                rendered_query,
+                return_results=True)
             payload = json.dumps(
                 data, default=utils.pessimistic_json_iso_dttm_ser, ignore_nan=True)
         except Exception as e:


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org