You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/01/15 16:58:33 UTC
[GitHub] [maven] hboutemy opened a new pull request #660: [MNG-7391] add execution strategy+runner required by Maven Build Cache
hboutemy opened a new pull request #660:
URL: https://github.com/apache/maven/pull/660
https://issues.apache.org/jira/browse/MNG-7391
supercedes #622
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #660: [MNG-7391] add execution strategy+runner required by Maven Build Cache
Posted by GitBox <gi...@apache.org>.
michael-o commented on a change in pull request #660:
URL: https://github.com/apache/maven/pull/660#discussion_r787663794
##########
File path: maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycles.java
##########
@@ -43,7 +43,7 @@
@Component( role = DefaultLifecycles.class )
public class DefaultLifecycles
{
- public static final String[] STANDARD_LIFECYCLES = { "default", "clean", "site" };
+ public static final String[] STANDARD_LIFECYCLES = { "clean", "default", "site" };
Review comment:
Is this a fix? How it is related to this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on a change in pull request #660: [3.8.x][MNG-7391] add execution strategy+runner required by Maven Build Cache
Posted by GitBox <gi...@apache.org>.
gnodet commented on a change in pull request #660:
URL: https://github.com/apache/maven/pull/660#discussion_r801500059
##########
File path: maven-core/src/main/java/org/apache/maven/lifecycle/DefaultLifecycles.java
##########
@@ -43,7 +43,7 @@
@Component( role = DefaultLifecycles.class )
public class DefaultLifecycles
{
- public static final String[] STANDARD_LIFECYCLES = { "default", "clean", "site" };
+ public static final String[] STANDARD_LIFECYCLES = { "clean", "default", "site" };
Review comment:
See https://github.com/apache/maven/pull/661/files#r801487087
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet closed pull request #660: [3.9.x][MNG-7391] add execution strategy+runner required by Maven Build Cache
Posted by GitBox <gi...@apache.org>.
gnodet closed pull request #660:
URL: https://github.com/apache/maven/pull/660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] michael-o commented on pull request #660: [3.8.x][MNG-7391] add execution strategy+runner required by Maven Build Cache
Posted by GitBox <gi...@apache.org>.
michael-o commented on pull request #660:
URL: https://github.com/apache/maven/pull/660#issuecomment-1032480496
Does this really make sense on 3.8.x? I would expect that Build Cache is 3.9+?!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #660: [3.9.x][MNG-7391] add execution strategy+runner required by Maven Build Cache
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #660:
URL: https://github.com/apache/maven/pull/660#issuecomment-1032605615
> Does this really make sense on 3.8.x? I would expect that Build Cache is 3.9+?!
The target is definitely 3.9.x. I renamed to `[3.8.x]` to target the branch. As soon as 3.8.5 is done, the plan is to create a 3.9.x branch and merge this PR there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] gnodet commented on pull request #660: [3.9.x][MNG-7391] add execution strategy+runner required by Maven Build Cache
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #660:
URL: https://github.com/apache/maven/pull/660#issuecomment-1062783259
Fixed with https://github.com/apache/maven/commit/1954d51ff2841045b4af8a515ad0719805269d8d
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org