You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "alexswo (via GitHub)" <gi...@apache.org> on 2023/06/06 21:00:36 UTC

[GitHub] [arrow] alexswo commented on a diff in pull request #35582: GH-34787: [Python] Accept zero_copy_only=False for ChunkedArray.to_numpy

alexswo commented on code in PR #35582:
URL: https://github.com/apache/arrow/pull/35582#discussion_r1220356728


##########
python/pyarrow/table.pxi:
##########
@@ -491,6 +497,11 @@ cdef class ChunkedArray(_PandasConvertible):
             PandasOptions c_options
             object values
 
+        if zero_copy_only:

Review Comment:
   nit, how about putting the `if/raise` statement before the `cdef`? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org