[GitHub] [flink] WeiZhong94 commented on a change in pull request #8563: [FLINK-12602][travis] Correct the flink pom `artifactId` config and s…

[GitBox <gi...@apache.org>]

WeiZhong94 commented on a change in pull request #8563: [FLINK-12602][travis] Correct the flink pom `artifactId` config and s…
URL: https://github.com/apache/flink/pull/8563#discussion_r291866343
 
 

 ##########
 File path: flink-connectors/flink-sql-connector-kafka-0.10/pom.xml
 ##########
 @@ -41,6 +41,14 @@ under the License.
 			<artifactId>flink-connector-kafka-0.10_${scala.binary.version}</artifactId>
 			<version>${project.version}</version>
 		</dependency>
+		<!--  Due to the scope of `provided` transitive dependencies problem,
 
 Review comment:
   I think current PR is a more conservative approach. Do you mean that if a flink module depends on another flink module with a scala suffix, it is also considered dependent on scala? I considered this rule, but I am not sure if it was correct. Such as a module which depends on a scala-suffix module with "provided" scope, and only uses the interfaces provided by the scala-suffix module itself, regardless of the actual scala version of the runtime. May such a module exist? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services