[jira] [Comment Edited] (SLING-11408) Make sure that feature launcher contains only necessary runtime dependencies

["Konrad Windszus (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLING-11408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17557876#comment-17557876 ] 

Konrad Windszus edited comment on SLING-11408 at 6/23/22 8:27 AM:
------------------------------------------------------------------

Currently the lib folder is containing too many libraries (which are actually not necessary at run time). This is due to the fact that {{useWildcardClassPath}} is set to {{true}} (https://www.mojohaus.org/appassembler/appassembler-maven-plugin/assemble-mojo.html#useWildcardClassPath). Instead one should work with the regular Maven scope "compile" and "provided".

Currently there is the following JARs in the lib folder

# biz.aQute.bnd.annotation-6.3.1.jar
# commons-cli-1.4.jar
# commons-lang3-3.12.0.jar
# commons-text-1.9.jar
# org.apache.felix.cm.json-1.0.6.jar
# org.apache.sling.commons.johnzon-1.2.14.jar
# org.apache.sling.feature-1.2.30.jar
# org.apache.sling.feature.launcher-1.2.1-SNAPSHOT.jar
# org.osgi.annotation.versioning-1.1.1.jar
# org.osgi.resource-1.0.0.jar
# org.osgi.service.serviceloader-1.0.0.jar
# org.osgi.util.converter-1.0.9.jar
# org.osgi.util.function-1.0.0.jar
# osgi.core-8.0.0.jar
# slf4j-api-1.7.25.jar
# slf4j-simple-1.7.25.jar


was (Author: kwin):
Currently the lib folder is containing too many libraries (which are actually not necessary at run time). This is due to the fact that {{useWildcardClassPath}} is set to {{true}} (https://www.mojohaus.org/appassembler/appassembler-maven-plugin/assemble-mojo.html#useWildcardClassPath). Instead one should work with the regular Maven scope "compile" and "provided".

> Make sure that feature launcher contains only necessary runtime dependencies
> ----------------------------------------------------------------------------
>
>                 Key: SLING-11408
>                 URL: https://issues.apache.org/jira/browse/SLING-11408
>             Project: Sling
>          Issue Type: Improvement
>          Components: Feature Model
>    Affects Versions: Feature Model Launcher 1.2.0
>            Reporter: Konrad Windszus
>            Assignee: Konrad Windszus
>            Priority: Major
>
> Feature Launcher uses {{appassembler-maven-plugin}} for packaging all runtime dependencies into the classpath. As a lot of required dependencies have scope "provided" (due to primary usage within OSGi) it is hard to come up with a correct runtime classpath. The enforcer rule from SLING-11369 should be leveraged to automatically enforce a complete runtime classpath.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)