You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "JosiahWI (via GitHub)" <gi...@apache.org> on 2023/06/16 11:23:27 UTC
[GitHub] [trafficserver] JosiahWI opened a new pull request, #9862: Add support for libunwind in CMake build
JosiahWI opened a new pull request, #9862:
URL: https://github.com/apache/trafficserver/pull/9862
This adds an option that defaults to ON: ENABLE_UNWIND. On Linux, CMake will look for the library and link it globally if it is found. On other OSs, CMake will skip the check, because libunwind is only available on Linux.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] JosiahWI commented on pull request #9862: Add support for libunwind in CMake build
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #9862:
URL: https://github.com/apache/trafficserver/pull/9862#issuecomment-1594661646
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] JosiahWI commented on pull request #9862: Add support for libunwind in CMake build
Posted by "JosiahWI (via GitHub)" <gi...@apache.org>.
JosiahWI commented on PR #9862:
URL: https://github.com/apache/trafficserver/pull/9862#issuecomment-1594942795
It's being linked globally. The header isn't included anywhere specifically in ATS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt merged pull request #9862: Add support for libunwind in CMake build
Posted by "bneradt (via GitHub)" <gi...@apache.org>.
bneradt merged PR #9862:
URL: https://github.com/apache/trafficserver/pull/9862
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] cmcfarlen commented on a diff in pull request #9862: Add support for libunwind in CMake build
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on code in PR #9862:
URL: https://github.com/apache/trafficserver/pull/9862#discussion_r1232462462
##########
CMakeLists.txt:
##########
@@ -150,6 +151,12 @@ if(TSMallocReplacement_FOUND)
link_libraries(ts::TSMallocReplacement)
endif()
+if(CMAKE_SYSTEM_NAME STREQUAL "Linux" AND ENABLE_UNWIND)
+ find_package(unwind REQUIRED)
+ link_libraries(unwind::unwind)
+ set(TS_USE_REMOTE_UNWINDING TRUE)
+endif()
+
Review Comment:
There is already a linux specific section below. Perhaps move this inside that so they are consolidated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org