[GitHub] [skywalking-banyandb-java-client] hailin0 commented on a diff in pull request #47: [E2E Testing] Publish customize oap image

["hailin0 (via GitHub)" <gi...@apache.org>]

hailin0 commented on code in PR #47:
URL: https://github.com/apache/skywalking-banyandb-java-client/pull/47#discussion_r1327338277


##########
src/main/proto/banyandb/v1/banyandb-stream.proto:
##########
@@ -84,13 +84,22 @@ message ElementValue {
 }
 
 message WriteRequest {
-  // the metadata is only required in the first write.
+  // the metadata is required.
   common.v1.Metadata metadata = 1 [(validate.rules).message.required = true];
   // the element is required.
   ElementValue element = 2 [(validate.rules).message.required = true];
+  // the message_id is required.
+  uint64 message_id = 3 [(validate.rules).uint64.gt = 0];
 }
 
-message WriteResponse {}
+message WriteResponse {
+  // the message_id from request.
+  uint64 message_id = 1 [(validate.rules).uint64.gt = 0];
+  // status indicates the request processing result
+  model.v1.Status status = 2 [(validate.rules).enum.defined_only = true];
+  // the metadata from request when request fails
+  common.v1.Metadata metadata = 3 [(validate.rules).message.required = true];

Review Comment:
   @hanahmily 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org