You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/05/23 08:46:24 UTC
[GitHub] [dolphinscheduler] SnowMoon-Dev opened a new pull request, #10201: [Fix-10199] [Workflow/Workflow Definition] After deleting messages in batches, the error message is repeated
SnowMoon-Dev opened a new pull request, #10201:
URL: https://github.com/apache/dolphinscheduler/pull/10201
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
## Brief change log
close [#10199](https://github.com/apache/dolphinscheduler/issues/10199)
## Verify this pull request
Manually verified the change by testing locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10201: [Fix-10199] [Workflow/Workflow Definition] After deleting messages in batches, the error message is repeated
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10201:
URL: https://github.com/apache/dolphinscheduler/pull/10201#discussion_r879208168
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java:
##########
@@ -637,25 +637,25 @@ public Result batchDeleteProcessDefinitionByCodes(@ApiIgnore @RequestAttribute(v
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@RequestParam("codes") String codes) {
Map<String, Object> result = new HashMap<>();
- List<String> deleteFailedCodeList = new ArrayList<>();
+ Set<String> deleteFailedCodeSet = new HashSet<>();
Review Comment:
I think this could not solve this problem. The reason for this error is that the current user does not have permissions of the workflow definition created by other users. Currently, only administrator users can delete workflow definitions created by other users.
https://github.com/apache/dolphinscheduler/blob/41a318381067b285a03001e9ef43d8eaa107ff6a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java#L707-L710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10201: [Fix-10199] [Workflow/Workflow Definition] After deleting messages in batches, the error message is repeated
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10201:
URL: https://github.com/apache/dolphinscheduler/pull/10201#issuecomment-1134407173
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10201)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10201&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10201&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10201&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10201&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10201&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10201&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10201&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10201&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10201&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10201&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10201&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10201&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10201&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10201&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10201&metric=new_duplicated_lines_density&view=list) [0.0% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10201&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SnowMoon-Dev commented on pull request #10201: [Fix-10199] [Workflow/Workflow Definition] After deleting messages in batches, the error message is repeated
Posted by GitBox <gi...@apache.org>.
SnowMoon-Dev commented on PR #10201:
URL: https://github.com/apache/dolphinscheduler/pull/10201#issuecomment-1136135586
> I think we should not improve the error log instead of using a hash set to correct it. It should be `user has no operation privilege to delete <workflowname1> <workflowname2>`. more specific and user firendly
In the case of a single deletion, the user knows the name of the workflow to be deleted, so there is no need to give corresponding reminders. In the scenario of batch deletion, if there are too many reminders, it will also cause trouble for the user, because deletion is an important operation, the user should be careful to know the name of the workflow to be deleted, so a single error message is prompted, I think it is also possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] codecov-commenter commented on pull request #10201: [Fix-10199] [Workflow/Workflow Definition] After deleting messages in batches, the error message is repeated
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #10201:
URL: https://github.com/apache/dolphinscheduler/pull/10201#issuecomment-1134399896
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10201?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#10201](https://codecov.io/gh/apache/dolphinscheduler/pull/10201?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ef6eac1) into [dev](https://codecov.io/gh/apache/dolphinscheduler/commit/7a8f3f1810ec283fc5acd66077d46db88b0400af?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a8f3f1) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head ef6eac1 differs from pull request most recent head fb7d2e9. Consider uploading reports for the commit fb7d2e9 to get more accurate results
```diff
@@ Coverage Diff @@
## dev #10201 +/- ##
============================================
- Coverage 40.94% 40.93% -0.02%
+ Complexity 4732 4728 -4
============================================
Files 854 854
Lines 34553 34553
Branches 3818 3818
============================================
- Hits 14148 14143 -5
- Misses 19051 19056 +5
Partials 1354 1354
```
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler/pull/10201?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...er/api/controller/ProcessDefinitionController.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10201/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvYXBpL2NvbnRyb2xsZXIvUHJvY2Vzc0RlZmluaXRpb25Db250cm9sbGVyLmphdmE=) | `45.34% <0.00%> (ø)` | |
| [...er/master/dispatch/host/assign/RandomSelector.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10201/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1tYXN0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvc2VydmVyL21hc3Rlci9kaXNwYXRjaC9ob3N0L2Fzc2lnbi9SYW5kb21TZWxlY3Rvci5qYXZh) | `77.77% <0.00%> (-5.56%)` | :arrow_down: |
| [...org/apache/dolphinscheduler/remote/utils/Host.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10201/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL3V0aWxzL0hvc3QuamF2YQ==) | `37.77% <0.00%> (-2.23%)` | :arrow_down: |
| [...dolphinscheduler/remote/future/ResponseFuture.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10201/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL2Z1dHVyZS9SZXNwb25zZUZ1dHVyZS5qYXZh) | `81.96% <0.00%> (-1.64%)` | :arrow_down: |
| [...e/dolphinscheduler/remote/NettyRemotingClient.java](https://codecov.io/gh/apache/dolphinscheduler/pull/10201/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZG9scGhpbnNjaGVkdWxlci1yZW1vdGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2RvbHBoaW5zY2hlZHVsZXIvcmVtb3RlL05ldHR5UmVtb3RpbmdDbGllbnQuamF2YQ==) | `52.11% <0.00%> (-1.41%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10201?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dolphinscheduler/pull/10201?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [41a3183...fb7d2e9](https://codecov.io/gh/apache/dolphinscheduler/pull/10201?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SnowMoon-Dev commented on a diff in pull request #10201: [Fix-10199] [Workflow/Workflow Definition] After deleting messages in batches, the error message is repeated
Posted by GitBox <gi...@apache.org>.
SnowMoon-Dev commented on code in PR #10201:
URL: https://github.com/apache/dolphinscheduler/pull/10201#discussion_r879232164
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java:
##########
@@ -637,25 +637,25 @@ public Result batchDeleteProcessDefinitionByCodes(@ApiIgnore @RequestAttribute(v
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@RequestParam("codes") String codes) {
Map<String, Object> result = new HashMap<>();
- List<String> deleteFailedCodeList = new ArrayList<>();
+ Set<String> deleteFailedCodeSet = new HashSet<>();
Review Comment:
Good idea, I'll add this description to the documentation later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10201: [Fix-10199] [Workflow/Workflow Definition] After deleting messages in batches, the error message is repeated
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10201:
URL: https://github.com/apache/dolphinscheduler/pull/10201#discussion_r879222663
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java:
##########
@@ -637,25 +637,25 @@ public Result batchDeleteProcessDefinitionByCodes(@ApiIgnore @RequestAttribute(v
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@RequestParam("codes") String codes) {
Map<String, Object> result = new HashMap<>();
- List<String> deleteFailedCodeList = new ArrayList<>();
+ Set<String> deleteFailedCodeSet = new HashSet<>();
Review Comment:
I think we should add this administrator condition to the batch delete docs. So that we can prevent misunstanding when users use this function. @SnowMoon-Dev
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SnowMoon-Dev commented on a diff in pull request #10201: [Fix-10199] [Workflow/Workflow Definition] After deleting messages in batches, the error message is repeated
Posted by GitBox <gi...@apache.org>.
SnowMoon-Dev commented on code in PR #10201:
URL: https://github.com/apache/dolphinscheduler/pull/10201#discussion_r879218404
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java:
##########
@@ -637,25 +637,25 @@ public Result batchDeleteProcessDefinitionByCodes(@ApiIgnore @RequestAttribute(v
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@RequestParam("codes") String codes) {
Map<String, Object> result = new HashMap<>();
- List<String> deleteFailedCodeList = new ArrayList<>();
+ Set<String> deleteFailedCodeSet = new HashSet<>();
Review Comment:
Yes, only the administrator user can delete the workflow created by other users, and the delete operation is an important operation. The one created by oneself can be deleted or the administrator can delete it. I think this logic is correct at present, but the printing There is duplication of information, so I made a bug fix for the duplicate error information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #10201: [Fix-10199] [Workflow/Workflow Definition] After deleting messages in batches, the error message is repeated
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #10201:
URL: https://github.com/apache/dolphinscheduler/pull/10201#issuecomment-1136037849
I think we should not improve the error log instead of using a hash set to correct it. It should be `user has no operation privilege to delete <workflowname1> <workflowname2>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS merged pull request #10201: [Fix-10199] [Workflow/Workflow Definition] After deleting messages in batches, the error message is repeated
Posted by GitBox <gi...@apache.org>.
SbloodyS merged PR #10201:
URL: https://github.com/apache/dolphinscheduler/pull/10201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SnowMoon-Dev commented on a diff in pull request #10201: [Fix-10199] [Workflow/Workflow Definition] After deleting messages in batches, the error message is repeated
Posted by GitBox <gi...@apache.org>.
SnowMoon-Dev commented on code in PR #10201:
URL: https://github.com/apache/dolphinscheduler/pull/10201#discussion_r879228701
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java:
##########
@@ -637,25 +637,25 @@ public Result batchDeleteProcessDefinitionByCodes(@ApiIgnore @RequestAttribute(v
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@RequestParam("codes") String codes) {
Map<String, Object> result = new HashMap<>();
- List<String> deleteFailedCodeList = new ArrayList<>();
+ Set<String> deleteFailedCodeSet = new HashSet<>();
Review Comment:
> If this pr is just aimed to solve the duplicated error message. Then it's ok to me.
ok, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SnowMoon-Dev commented on pull request #10201: [Fix-10199] [Workflow/Workflow Definition] After deleting messages in batches, the error message is repeated
Posted by GitBox <gi...@apache.org>.
SnowMoon-Dev commented on PR #10201:
URL: https://github.com/apache/dolphinscheduler/pull/10201#issuecomment-1134948568
@zhongjiajie @SbloodyS Please also merge this pr, https://github.com/apache/dolphinscheduler/issues/10199 This bug has been closed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10201: [Fix-10199] [Workflow/Workflow Definition] After deleting messages in batches, the error message is repeated
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10201:
URL: https://github.com/apache/dolphinscheduler/pull/10201#discussion_r879208168
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java:
##########
@@ -637,25 +637,25 @@ public Result batchDeleteProcessDefinitionByCodes(@ApiIgnore @RequestAttribute(v
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@RequestParam("codes") String codes) {
Map<String, Object> result = new HashMap<>();
- List<String> deleteFailedCodeList = new ArrayList<>();
+ Set<String> deleteFailedCodeSet = new HashSet<>();
Review Comment:
I think this could not solve this problems. The reason for this error is that the current user does not have permissions of the workflow definition created by other users. Currently, only administrator users can delete workflow definitions created by other users.
https://github.com/apache/dolphinscheduler/blob/41a318381067b285a03001e9ef43d8eaa107ff6a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/ProcessDefinitionServiceImpl.java#L707-L710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on a diff in pull request #10201: [Fix-10199] [Workflow/Workflow Definition] After deleting messages in batches, the error message is repeated
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on code in PR #10201:
URL: https://github.com/apache/dolphinscheduler/pull/10201#discussion_r879217603
##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/controller/ProcessDefinitionController.java:
##########
@@ -637,25 +637,25 @@ public Result batchDeleteProcessDefinitionByCodes(@ApiIgnore @RequestAttribute(v
@ApiParam(name = "projectCode", value = "PROJECT_CODE", required = true) @PathVariable long projectCode,
@RequestParam("codes") String codes) {
Map<String, Object> result = new HashMap<>();
- List<String> deleteFailedCodeList = new ArrayList<>();
+ Set<String> deleteFailedCodeSet = new HashSet<>();
Review Comment:
If this pr is just aimed to solve the duplicated error message. Then it's ok to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org