Re: [PR] MINOR: Rewrite the meta.properties handling code in Java and fix some issues [kafka]

["chia7712 (via GitHub)" <gi...@apache.org>]

chia7712 commented on code in PR #14628:
URL: https://github.com/apache/kafka/pull/14628#discussion_r1672494554


##########
core/src/main/scala/kafka/tools/StorageTool.scala:
##########
@@ -60,7 +63,11 @@ object StorageTool extends Logging {
           if (!metadataVersion.isKRaftSupported) {
             throw new TerseFailure(s"Must specify a valid KRaft metadata version of at least 3.0.")
           }
-          val metaProperties = buildMetadataProperties(clusterId, config.get)

Review Comment:
   @cmccabe Sorry for making noise in this merged PR, but I have a question about valid "cluster id"
   
   Before this patch, the `cluster id` was required to be a "valid" UUID (`buildMetadataProperties` does validation). For example, the length must be larger than 24. However, this patch removed the validation of UUID and hence we can start a cluster with non-uuid cluster id. Is this change expected?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org