[GitHub] [arrow] fsaintjacques commented on a change in pull request #7223: ARROW-8711: [Python] Expose timestamp_parsers in csv.ConvertOptions

[GitBox <gi...@apache.org>]

fsaintjacques commented on a change in pull request #7223:
URL: https://github.com/apache/arrow/pull/7223#discussion_r433909097



##########
File path: cpp/src/arrow/util/value_parsing.h
##########
@@ -45,6 +45,10 @@ class ARROW_EXPORT TimestampParser {
   virtual bool operator()(const char* s, size_t length, TimeUnit::type out_unit,
                           int64_t* out) const = 0;
 
+  virtual const char* kind() const = 0;
+
+  virtual const char* detail() const;

Review comment:
       Do you need this to be virtual?

##########
File path: python/pyarrow/_csv.pyx
##########
@@ -296,10 +297,31 @@ cdef class ParseOptions:
         out.options = options
         return out
 
-    def __reduce__(self):
-        return ParseOptions, (self.delimiter, self.quote_char,
-                              self.double_quote, self.escape_char,
-                              self.newlines_in_values, self.ignore_empty_lines)
+    def __getstate__(self):
+        return (self.delimiter, self.quote_char, self.double_quote,
+                self.escape_char, self.newlines_in_values,
+                self.ignore_empty_lines)
+
+    def __setstate__(self, state):
+        (self.delimiter, self.quote_char, self.double_quote,
+         self.escape_char, self.newlines_in_values,
+         self.ignore_empty_lines) = state
+
+
+cdef class _ISO8601:

Review comment:
       Why not make an equivalent class for `strptime`? That would make timestamp_parsers's setter more robust to refactor, e.g. a new field in the wrapped c++ class. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org