You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "yasserzamani (via GitHub)" <gi...@apache.org> on 2023/02/26 11:10:36 UTC

[GitHub] [struts] yasserzamani commented on a diff in pull request #662: [WW-5285] Limits max number of files to upload at once

yasserzamani commented on code in PR #662:
URL: https://github.com/apache/struts/pull/662#discussion_r1118064990


##########
core/src/main/java/org/apache/struts2/dispatcher/multipart/AbstractMultiPartRequest.java:
##########
@@ -54,6 +54,12 @@ public abstract class AbstractMultiPartRequest implements MultiPartRequest {
     protected long maxSize;
     protected boolean maxSizeProvided;
 
+    /**
+     * Specifies the maximum number of files in one request.
+     */
+    protected long maxFiles;
+    protected boolean maxFilesProvided;

Review Comment:
   nitpick: can't we use Long instead of long here? and a null value will mean that it's not provided



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@struts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org