[jira] Commented: (HADOOP-4501) CLI not supporting multiline queries from an input file

["Ashish Thusoo (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-4501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12642207#action_12642207 ] 

Ashish Thusoo commented on HADOOP-4501:
---------------------------------------

Hi Jeremy,

Thanks a bunch for the patch. 

One comment though - it would be great if the patch is able to pass all the empty lines around to the parser for debuggability purposes. Otherwise, it will be impossible for the users to figure out where the error happened in a statement. 

you bring up a good point about processLine calling the trim function. We should move that to the checks in processCmd and not trim the line in processLine and we should pass the command as is to qp.run(cmd) call in processCmd.

What do think?

> CLI not supporting multiline queries from an input file
> -------------------------------------------------------
>
>                 Key: HADOOP-4501
>                 URL: https://issues.apache.org/jira/browse/HADOOP-4501
>             Project: Hadoop Core
>          Issue Type: Improvement
>          Components: contrib/hive
>    Affects Versions: 0.17.3
>            Reporter: Jeremy Huylebroeck
>            Priority: Trivial
>             Fix For: 0.17.3
>
>         Attachments: patch-0.17.txt, patch-trunk.txt
>
>
> calling "hive -f filename" allows to pass HQL queries from a file.
> but the queries can't be on multiple lines as we would expect by reading Hive documentation.
> a proposed fix is to modify CliDriver.processReader.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.