[GitHub] john-bodley commented on a change in pull request #5567: make filters use security manager

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #5567: make filters use security manager
URL: https://github.com/apache/incubator-superset/pull/5567#discussion_r208098517
 
 

 ##########
 File path: superset/security.py
 ##########
 @@ -85,6 +85,15 @@ def get_schema_perm(self, database, schema):
         if schema:
             return '[{}].[{}]'.format(database, schema)
 
+    def always_list_all_dashboards(self):
 
 Review comment:
   I agree with your comment that we should defer to the security manager to answer said question, however I’m not sure we need these always_ methods.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org