You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by GitBox <gi...@apache.org> on 2022/12/04 00:05:39 UTC

[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #71: Rename sbt akka modules

pjfanning commented on code in PR #71:
URL: https://github.com/apache/incubator-pekko/pull/71#discussion_r1038887167


##########
LICENSE:
##########
@@ -207,6 +207,6 @@ Licenses for dependency projects can be found here:
 
 ---------------
 
-akka-protobuf contains the sources of Google protobuf 2.5.0 runtime support,
+protobuf contains the sources of Google protobuf 2.5.0 runtime support,

Review Comment:
   Could this be changed to`pekko-protobuf module contains`?  The dir rename makes this statement very ambiguous. The Notice should be use the jar name as opposed to the dir name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org