You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/02/10 18:22:31 UTC
[GitHub] [fineract] fynmanoj opened a new pull request #2031: FINERACT-1499-DB-connection-exception-fix-for-bootRun
fynmanoj opened a new pull request #2031:
URL: https://github.com/apache/fineract/pull/2031
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [ ] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [ ] Create/update unit or integration tests for verifying the changes made.
- [ ] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [ ] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] fynmanoj edited a comment on pull request #2031: FINERACT-1499-DB-connection-exception-fix-for-bootRun
Posted by GitBox <gi...@apache.org>.
fynmanoj edited a comment on pull request #2031:
URL: https://github.com/apache/fineract/pull/2031#issuecomment-1035290606
@ptuomola, @vorburger, @vidakovic please check this. This is blocking local bootRun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #2031: FINERACT-1499-DB-connection-exception-fix-for-bootRun
Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #2031:
URL: https://github.com/apache/fineract/pull/2031#issuecomment-1035326701
@fynmanoj I will try this again... I remember that I've investigated that and found a Stackoverflow entry (a bit old) that mentioned that this (single quotes) would not be necessary anymore... and I don't remember running into issues when I tested this... good to have more eye balls on this... Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #2031: FINERACT-1499-DB-connection-exception-fix-for-bootRun
Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #2031:
URL: https://github.com/apache/fineract/pull/2031#issuecomment-1036444321
@fynmanoj thanks again for this one... just in time another colleague stumbled upon it and needed the fix. :clap:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] fynmanoj commented on pull request #2031: FINERACT-1499-DB-connection-exception-fix-for-bootRun
Posted by GitBox <gi...@apache.org>.
fynmanoj commented on pull request #2031:
URL: https://github.com/apache/fineract/pull/2031#issuecomment-1035290606
@ptuomola, @vorburger, @vidakovic please check this. This is blocking by local bootRun.
ref : https://stackoverflow.com/questions/62875244/caused-by-java-lang-runtimeexception-driver-com-mysql-cj-jdbc-driver-claims-to?rq=1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] fynmanoj edited a comment on pull request #2031: FINERACT-1499-DB-connection-exception-fix-for-bootRun
Posted by GitBox <gi...@apache.org>.
fynmanoj edited a comment on pull request #2031:
URL: https://github.com/apache/fineract/pull/2031#issuecomment-1035290606
@ptuomola, @vorburger, @vidakovic please check this. This is blocking by local bootRun.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic merged pull request #2031: FINERACT-1499-DB-connection-exception-fix-for-bootRun
Posted by GitBox <gi...@apache.org>.
vidakovic merged pull request #2031:
URL: https://github.com/apache/fineract/pull/2031
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic edited a comment on pull request #2031: FINERACT-1499-DB-connection-exception-fix-for-bootRun
Posted by GitBox <gi...@apache.org>.
vidakovic edited a comment on pull request #2031:
URL: https://github.com/apache/fineract/pull/2031#issuecomment-1035326701
@fynmanoj I will try this again... I remember that I've investigated that and found a Stackoverflow entry (a bit old) that mentioned that this (single quotes) would not be necessary anymore... and I don't remember running into issues when I tested this and if there was a problem it should have failed with the integration tests... anyway, good to have more eye balls on this... Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org