[jira] [Work logged] (HIVE-23751) QTest: Override #mkdirs() method in ProxyFileSystem To Align After HADOOP-16582

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HIVE-23751?focusedWorklogId=453497&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-453497 ]

ASF GitHub Bot logged work on HIVE-23751:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Jul/20 16:16
            Start Date: 01/Jul/20 16:16
    Worklog Time Spent: 10m 
      Work Description: kgyrtkirk commented on pull request #1167:
URL: https://github.com/apache/hive/pull/1167#issuecomment-652514691


   @shameersss1 : I think your email address is "sra?man@qubole.com" but github wants to add it only as a "Co-Authored" thing 
    and when it used to do this - it usually changes the author's email address to "something@users.noreply.github.com" 
   
   there are 2 things which could cause this at https://github.com/settings/emails :
   * you don't have your email address associated with your github account
   * you have the "keep my address private" checked
   
   but...if you want me to merge it with "@users.noreply.github.com" just let me know :D


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 453497)
    Time Spent: 20m  (was: 10m)

> QTest: Override #mkdirs() method in ProxyFileSystem To Align After HADOOP-16582
> -------------------------------------------------------------------------------
>
>                 Key: HIVE-23751
>                 URL: https://issues.apache.org/jira/browse/HIVE-23751
>             Project: Hive
>          Issue Type: Task
>            Reporter: Syed Shameerur Rahman
>            Assignee: Syed Shameerur Rahman
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 4.0.0, 3.2.0
>
>         Attachments: HIVE-23751.01.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> HADOOP-16582 have changed the way how mkdirs() work:
> *Before HADOOP-16582:*
> All calls to mkdirs(p) were fast-tracked to FileSystem.mkdirs which were then re-routed to mkdirs(p, permission) method. For ProxyFileSytem the call would look like
> {code:java}
> FileUtiles.mkdir(p)  ----->  FileSystem.mkdirs(p) ---> ProxyFileSytem.mkdirs(p,permission)
> {code}
> An implementation of FileSystem have only needed implement mkdirs(p, permission)
> *After HADOOP-16582:*
> Since FilterFileSystem overrides mkdirs(p) method the new call to ProxyFileSystem would look like
> {code:java}
> FileUtiles.mkdir(p) ---> FilterFileSystem.mkdirs(p) -->
> {code}
> This will make all the qtests fails with the below exception 
> {code:java}
> Caused by: java.lang.IllegalArgumentException: Wrong FS: pfile:/media/ebs1/workspace/hive-3.1-qtest/group/5/label/HiveQTest/hive-1.2.0/itests/qtest/target/warehouse/dest1, expected: file:///
> {code}
> Note: We will hit this issue when we bump up hadoop version in hive.
> So as per the discussion in HADOOP-16963 ProxyFileSystem would need to override the mkdirs(p) method inorder to solve the above problem. So now the new flow would look like
> {code:java}
> FileUtiles.mkdir(p)  ---->   ProxyFileSytem.mkdirs(p) ---> ProxyFileSytem.mkdirs(p, permission) --->
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)