You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/11 11:33:20 UTC

[GitHub] [spark] xianyinxin opened a new pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2

xianyinxin opened a new pull request #25115: [SPARK-28351][SQL] Support DELETE in DataSource V2
URL: https://github.com/apache/spark/pull/25115
 
 
   ## What changes were proposed in this pull request?
   
   This pr adds DELETE support for V2 datasources. As a first step, this pr only support delete by source filters:
   ```scala
   void delete(Filter[] filters);
   ```
   which could not deal with complicated cases like subqueries.
   
   Since it's uncomfortable to embed the implementation of DELETE in the current V2 APIs, a new mix-in of datasource is added, which is called `SupportsMaintenance`, similar to `SupportsRead` and `SupportsWrite`.  A datasource which can be maintained means we can perform DELETE/UPDATE/MERGE/OPTIMIZE on the datasource, as long as the datasource implements the necessary mix-ins.
   
   ## How was this patch tested?
   
   new test case.
   
   Please review https://spark.apache.org/contributing.html before opening a pull request.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org