You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uniffle.apache.org by ro...@apache.org on 2023/03/19 11:17:10 UTC

[incubator-uniffle] branch branch-0.7 updated: [#669] improvement: refresh application when reading memory data (#741)

This is an automated email from the ASF dual-hosted git repository.

roryqi pushed a commit to branch branch-0.7
in repository https://gitbox.apache.org/repos/asf/incubator-uniffle.git


The following commit(s) were added to refs/heads/branch-0.7 by this push:
     new 7da715ed [#669] improvement: refresh application when reading memory data (#741)
7da715ed is described below

commit 7da715ed28325c6f1343bff71125022b9522cb97
Author: xianjingfeng <xi...@gmail.com>
AuthorDate: Sun Mar 19 19:15:51 2023 +0800

    [#669] improvement: refresh application when reading memory data (#741)
    
    ### What changes were proposed in this pull request?
    
    Refresh application when reading memory data.
    
    ### Why are the changes needed?
    
    In the current logic, application will not be refreshed when reading memory data. In this case, If timeout occurs when spark driver sends heartbeat to shuffle server, the application will be expired.
    
    Fix: #669
    
    ### Does this PR introduce _any_ user-facing change?
    
    No.
    
    ### How was this patch tested?
    
    No need,
---
 server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java | 1 +
 1 file changed, 1 insertion(+)

diff --git a/server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java b/server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java
index 32f56485..258de2e8 100644
--- a/server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java
+++ b/server/src/main/java/org/apache/uniffle/server/ShuffleTaskManager.java
@@ -453,6 +453,7 @@ public class ShuffleTaskManager {
   public ShuffleDataResult getInMemoryShuffleData(
       String appId, Integer shuffleId, Integer partitionId, long blockId, int readBufferSize,
       Roaring64NavigableMap expectedTaskIds) {
+    refreshAppId(appId);
     return shuffleBufferManager.getShuffleData(appId,
         shuffleId, partitionId, blockId, readBufferSize, expectedTaskIds);
   }