You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jasonxh <gi...@git.apache.org> on 2016/06/07 23:31:22 UTC
[GitHub] incubator-zeppelin pull request #973: [ZEPPELIN-973, ZEPPELIN-954] Table ren...
GitHub user jasonxh opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/973
[ZEPPELIN-973, ZEPPELIN-954] Table rendering improvements
### What is this PR for?
This PR fixes a few minor issues from the recent introduction of Handsontable for table rendering (https://github.com/apache/incubator-zeppelin/pull/858):
* Render up to 5 digits after decimal point instead of always rounding to integers
* Allow visual selection of table cells (for copy)
* Default to text renderer instead of numeric renderer
### What type of PR is it?
Bug Fix, Improvement
### Todos
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-973
* https://issues.apache.org/jira/browse/ZEPPELIN-954
### How should this be tested?
Output some rows with floating point numbers and render them in a table.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/optimizely/incubator-zeppelin hao/render-table
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/973.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #973
----
commit 7bc85b5af0edf1ba8dd63bbf2eee024ce5a065a0
Author: Hao Xia <ha...@optimizely.com>
Date: 2016-06-06T22:27:47Z
Table rendering improvements:
* Render up to 5 digits after decimal point
* Allow visual selection of table cells
* Default to text renderer
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #973: [ZEPPELIN-973, ZEPPELIN-954] Table rendering ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/973
@jasonxh I can't find you somehow on the JIRA user id.
Could you give it to me?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request #973: [ZEPPELIN-973, ZEPPELIN-954] Table ren...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/973
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #973: [ZEPPELIN-973, ZEPPELIN-954] Table rendering ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/973
@jasonxh Thanks for the fix
Next time if possible, please add a simple code example for testing, like:
```
print(s"""%table
name\tsize
sun\t127.6
moon\t0.6458
gerard\t45.234856803""")
```
It can save a lot of time to the reviewer :)
I tested and the decimal formating is working great, HTML and string rendering is still good too.
Regarding the selection cell for copy, I would advise to use both:
```
fragmentSelection: true,
disableVisualSelection: true,
```
This would remove the cell selection (with the border), and allow selection of the table text visually.
So except for that small configuration change, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #973: [ZEPPELIN-973, ZEPPELIN-954] Table rendering ...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/973
@corneadoug :)
@jasonxh Thanks for the fix. LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #973: [ZEPPELIN-973, ZEPPELIN-954] Table rendering ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/973
Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #973: [ZEPPELIN-973, ZEPPELIN-954] Table rendering ...
Posted by jasonxh <gi...@git.apache.org>.
Github user jasonxh commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/973
Thanks @corneadoug . I've updated the PR with your suggestions. I'll remember to paste a code snippet next time. :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin issue #973: [ZEPPELIN-973, ZEPPELIN-954] Table rendering ...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/incubator-zeppelin/pull/973
LGTM
Anybody's welcome to test it too
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---