You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/05/27 09:17:28 UTC
[GitHub] [maven-release] nielsbasjes opened a new pull request, #132: [MRELEASE-1096] Many cleanups and updates
nielsbasjes opened a new pull request, #132:
URL: https://github.com/apache/maven-release/pull/132
[MRELEASE-1096](https://issues.apache.org/jira/browse/MRELEASE-1096)
There is a lot of room for improvement.
- Some dependencies have inconsistent versions (slf4j)
- Some dependencies in the integration tests are ancient and some have todo points about workarounds for which the solution has been release ages ago.
- Junit 3 should be at least Junit 4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] nielsbasjes commented on a diff in pull request #132: [MRELEASE-1096] Many cleanups and updates
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on code in PR #132:
URL: https://github.com/apache/maven-release/pull/132#discussion_r883863885
##########
maven-release-plugin/pom.xml:
##########
@@ -109,7 +109,7 @@
<dependency>
<groupId>org.apache.maven.plugin-testing</groupId>
<artifactId>maven-plugin-testing-harness</artifactId>
- <version>3.3.0</version>
+ <version>${maven-plugin-testing-harness.version}</version>
Review Comment:
Ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] hboutemy commented on a diff in pull request #132: [MRELEASE-1096] Many cleanups and updates
Posted by GitBox <gi...@apache.org>.
hboutemy commented on code in PR #132:
URL: https://github.com/apache/maven-release/pull/132#discussion_r885085340
##########
maven-release-plugin/src/it/setup/maven-project-version-stub-policy/pom.xml:
##########
@@ -43,15 +43,15 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>2.0.2</version>
+ <version>@maven-compiler-plugin.version@</version>
<configuration>
<encoding>UTF-8</encoding>
</configuration>
</plugin>
<plugin>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-component-metadata</artifactId>
- <version>1.7.1</version>
+ <version>@plexus-component-metadata.version@</version>
Review Comment:
it's an IT
##########
maven-release-plugin/src/it/setup/maven-project-version-stub-policy/pom.xml:
##########
@@ -43,15 +43,15 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>2.0.2</version>
+ <version>@maven-compiler-plugin.version@</version>
<configuration>
<encoding>UTF-8</encoding>
</configuration>
</plugin>
<plugin>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-component-metadata</artifactId>
- <version>1.7.1</version>
+ <version>@plexus-component-metadata.version@</version>
Review Comment:
it's an IT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] michael-o commented on a diff in pull request #132: [MRELEASE-1096] Many cleanups and updates
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #132:
URL: https://github.com/apache/maven-release/pull/132#discussion_r885085787
##########
maven-release-plugin/src/it/setup/maven-project-version-stub-policy/pom.xml:
##########
@@ -43,15 +43,15 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>2.0.2</version>
+ <version>@maven-compiler-plugin.version@</version>
<configuration>
<encoding>UTF-8</encoding>
</configuration>
</plugin>
<plugin>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-component-metadata</artifactId>
- <version>1.7.1</version>
+ <version>@plexus-component-metadata.version@</version>
Review Comment:
Indeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] nielsbasjes commented on pull request #132: [MRELEASE-1096] Many cleanups and updates
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on PR #132:
URL: https://github.com/apache/maven-release/pull/132#issuecomment-1139437835
@michael-o As requested the separate cleanups.
Some dependencies have been updated, not all.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] nielsbasjes commented on a diff in pull request #132: [MRELEASE-1096] Many cleanups and updates
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on code in PR #132:
URL: https://github.com/apache/maven-release/pull/132#discussion_r883863624
##########
maven-release-plugin/src/it/projects/prepare/semver-policy/pom.xml:
##########
@@ -21,7 +21,7 @@
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>org.apache.maven.plugin.release.it</groupId>
- <artifactId>oddversion-policy</artifactId>
+ <artifactId>semver-policy</artifactId>
Review Comment:
I think this is a copy-paste error from long ago. It is just naming, doesn't really fix anything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] michael-o commented on a diff in pull request #132: [MRELEASE-1096] Many cleanups and updates
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #132:
URL: https://github.com/apache/maven-release/pull/132#discussion_r886007610
##########
maven-release-manager/src/test/resources/pomfinder/pom1.xml:
##########
@@ -193,7 +193,7 @@
<plugin>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-maven-plugin</artifactId>
- <version>1.3.8</version>
+ <version>@plexusMavenPluginVersion@</version>
Review Comment:
Note: This likely needs to be rewritten in the future with Sisu and annotations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] michael-o commented on a diff in pull request #132: [MRELEASE-1096] Many cleanups and updates
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #132:
URL: https://github.com/apache/maven-release/pull/132#discussion_r883804882
##########
maven-release-plugin/src/it/setup/maven-project-version-stub-policy/pom.xml:
##########
@@ -43,15 +43,15 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>2.0.2</version>
+ <version>@maven-compiler-plugin.version@</version>
<configuration>
<encoding>UTF-8</encoding>
</configuration>
</plugin>
<plugin>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-component-metadata</artifactId>
- <version>1.7.1</version>
+ <version>@plexus-component-metadata.version@</version>
Review Comment:
@cstamas Do we need this with Sisu?
##########
maven-release-plugin/pom.xml:
##########
@@ -109,7 +109,7 @@
<dependency>
<groupId>org.apache.maven.plugin-testing</groupId>
<artifactId>maven-plugin-testing-harness</artifactId>
- <version>3.3.0</version>
+ <version>${maven-plugin-testing-harness.version}</version>
Review Comment:
This is used only once, we can safely use the literal, this is what we do everywhere.
##########
maven-release-manager/pom.xml:
##########
@@ -284,7 +284,7 @@
<plugin>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-maven-plugin</artifactId>
- <version>1.3.8</version>
+ <version>${plexus-maven-plugin.version}</version>
Review Comment:
@cstamas Do we need this plugin at all?
##########
maven-release-plugin/src/it/projects/prepare/semver-policy/pom.xml:
##########
@@ -21,7 +21,7 @@
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<modelVersion>4.0.0</modelVersion>
<groupId>org.apache.maven.plugin.release.it</groupId>
- <artifactId>oddversion-policy</artifactId>
+ <artifactId>semver-policy</artifactId>
Review Comment:
Is that a bugfix?
##########
pom.xml:
##########
@@ -93,8 +96,20 @@
<resolverVersion>1.0.0.v20140518</resolverVersion>
<wagonVersion>3.5.1</wagonVersion>
<surefire.version>3.0.0-M6</surefire.version>
+ <slf4j.version>1.7.36</slf4j.version>
+ <junit.version>4.13.2</junit.version>
<maven.site.path>maven-release-archives/maven-release-LATEST</maven.site.path>
<project.build.outputTimestamp>2022-01-02T10:18:49Z</project.build.outputTimestamp>
+
+ <maven-compiler-plugin.version>3.10.1</maven-compiler-plugin.version>
+ <maven-artifact-transfer.version>0.13.1</maven-artifact-transfer.version>
+ <maven-invoker-plugin.version>3.2.2</maven-invoker-plugin.version>
+
+ <plexus-component-metadata.version>1.7.1</plexus-component-metadata.version>
+ <plexus-maven-plugin.version>1.3.8</plexus-maven-plugin.version>
+
+ <maven-plugin-testing-harness.version>3.3.0</maven-plugin-testing-harness.version>
Review Comment:
We tend to use camel case for those kind of properties, see here: https://github.com/apache/maven-scm/blob/b04525fa0716e6de7a65bf9970284efa0e49b177/pom.xml#L128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] nielsbasjes commented on a diff in pull request #132: [MRELEASE-1096] Many cleanups and updates
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on code in PR #132:
URL: https://github.com/apache/maven-release/pull/132#discussion_r885352045
##########
maven-release-manager/pom.xml:
##########
@@ -284,7 +284,7 @@
<plugin>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-maven-plugin</artifactId>
- <version>1.3.8</version>
+ <version>${plexus-maven-plugin.version}</version>
Review Comment:
That commit you mentioned seems to be committed.
Yet I still see this plugin in the master branch
https://github.com/apache/maven-release/blob/master/maven-release-manager/pom.xml#L284
What do you want me to change in this pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] nielsbasjes commented on a diff in pull request #132: [MRELEASE-1096] Many cleanups and updates
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on code in PR #132:
URL: https://github.com/apache/maven-release/pull/132#discussion_r885354347
##########
maven-release-manager/pom.xml:
##########
@@ -284,7 +284,7 @@
<plugin>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-maven-plugin</artifactId>
- <version>1.3.8</version>
+ <version>${plexus-maven-plugin.version}</version>
Review Comment:
I double checked and this specific code fragment was not removed as part of #118
Do you want me to remove it as part of this pull request?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] michael-o commented on pull request #132: [MRELEASE-1096] Many cleanups and updates
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #132:
URL: https://github.com/apache/maven-release/pull/132#issuecomment-1140509339
@cstamas Can you have a look at those two open questions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] hboutemy commented on a diff in pull request #132: [MRELEASE-1096] Many cleanups and updates
Posted by GitBox <gi...@apache.org>.
hboutemy commented on code in PR #132:
URL: https://github.com/apache/maven-release/pull/132#discussion_r885085122
##########
maven-release-manager/pom.xml:
##########
@@ -284,7 +284,7 @@
<plugin>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-maven-plugin</artifactId>
- <version>1.3.8</version>
+ <version>${plexus-maven-plugin.version}</version>
Review Comment:
this plugin has been removed in https://github.com/apache/maven-release/pull/118/files#diff-6b7a6eb88314d4014fb872beb2cc0edf29e6dde4f5f1059be3ff67bf03f3c305L211
##########
maven-release-manager/pom.xml:
##########
@@ -284,7 +284,7 @@
<plugin>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-maven-plugin</artifactId>
- <version>1.3.8</version>
+ <version>${plexus-maven-plugin.version}</version>
Review Comment:
this plugin has been removed in https://github.com/apache/maven-release/pull/118/files#diff-6b7a6eb88314d4014fb872beb2cc0edf29e6dde4f5f1059be3ff67bf03f3c305L211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] michael-o commented on a diff in pull request #132: [MRELEASE-1096] Many cleanups and updates
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #132:
URL: https://github.com/apache/maven-release/pull/132#discussion_r885766335
##########
maven-release-manager/pom.xml:
##########
@@ -284,7 +284,7 @@
<plugin>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-maven-plugin</artifactId>
- <version>1.3.8</version>
+ <version>${plexus-maven-plugin.version}</version>
Review Comment:
Drop it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] nielsbasjes commented on a diff in pull request #132: [MRELEASE-1096] Many cleanups and updates
Posted by GitBox <gi...@apache.org>.
nielsbasjes commented on code in PR #132:
URL: https://github.com/apache/maven-release/pull/132#discussion_r885797909
##########
maven-release-manager/pom.xml:
##########
@@ -284,7 +284,7 @@
<plugin>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-maven-plugin</artifactId>
- <version>1.3.8</version>
+ <version>${plexus-maven-plugin.version}</version>
Review Comment:
aaand it's gone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-release] asfgit closed pull request #132: [MRELEASE-1096] Many cleanups and updates
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #132: [MRELEASE-1096] Many cleanups and updates
URL: https://github.com/apache/maven-release/pull/132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org