You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by eb...@apache.org on 2011/11/09 14:56:16 UTC
svn commit: r1199761 - in /commons/sandbox/csv/trunk/src:
main/java/org/apache/commons/csv/ExtendedBufferedReader.java
test/java/org/apache/commons/csv/ExtendedBufferedReaderTest.java
Author: ebourg
Date: Wed Nov 9 13:56:16 2011
New Revision: 1199761
URL: http://svn.apache.org/viewvc?rev=1199761&view=rev
Log:
Removed an unused constructor in ExtendedBufferedReader
Modified:
commons/sandbox/csv/trunk/src/main/java/org/apache/commons/csv/ExtendedBufferedReader.java
commons/sandbox/csv/trunk/src/test/java/org/apache/commons/csv/ExtendedBufferedReaderTest.java
Modified: commons/sandbox/csv/trunk/src/main/java/org/apache/commons/csv/ExtendedBufferedReader.java
URL: http://svn.apache.org/viewvc/commons/sandbox/csv/trunk/src/main/java/org/apache/commons/csv/ExtendedBufferedReader.java?rev=1199761&r1=1199760&r2=1199761&view=diff
==============================================================================
--- commons/sandbox/csv/trunk/src/main/java/org/apache/commons/csv/ExtendedBufferedReader.java (original)
+++ commons/sandbox/csv/trunk/src/main/java/org/apache/commons/csv/ExtendedBufferedReader.java Wed Nov 9 13:56:16 2011
@@ -14,6 +14,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+
package org.apache.commons.csv;
import java.io.BufferedReader;
@@ -32,28 +33,21 @@ import java.io.Reader;
*/
class ExtendedBufferedReader extends BufferedReader {
-
- /**
- * the end of stream symbol
- */
+ /** The end of stream symbol */
public static final int END_OF_STREAM = -1;
- /**
- * undefined state for the lookahead char
- */
+
+ /** Undefined state for the lookahead char */
public static final int UNDEFINED = -2;
- /**
- * the lookahead chars
- */
+ /** The lookahead chars */
private int lookaheadChar = UNDEFINED;
- /**
- * the last char returned
- */
+
+ /** The last char returned */
private int lastChar = UNDEFINED;
- /**
- * the line counter
- */
+
+ /** The line counter */
private int lineCounter = 0;
+
private CharBuffer line = new CharBuffer();
/**
@@ -67,16 +61,6 @@ class ExtendedBufferedReader extends Buf
}
/**
- * Create extended buffered reader using the given buffer-size
- */
- public ExtendedBufferedReader(Reader r, int bufSize) {
- super(r, bufSize);
- /* note uh: do not fetch the first char here,
- * because this might block the method!
- */
- }
-
- /**
* Reads the next char from the input stream.
*
* @return the next char or END_OF_STREAM if end of stream has been reached.
Modified: commons/sandbox/csv/trunk/src/test/java/org/apache/commons/csv/ExtendedBufferedReaderTest.java
URL: http://svn.apache.org/viewvc/commons/sandbox/csv/trunk/src/test/java/org/apache/commons/csv/ExtendedBufferedReaderTest.java?rev=1199761&r1=1199760&r2=1199761&view=diff
==============================================================================
--- commons/sandbox/csv/trunk/src/test/java/org/apache/commons/csv/ExtendedBufferedReaderTest.java (original)
+++ commons/sandbox/csv/trunk/src/test/java/org/apache/commons/csv/ExtendedBufferedReaderTest.java Wed Nov 9 13:56:16 2011
@@ -26,15 +26,6 @@ import junit.framework.TestCase;
*/
public class ExtendedBufferedReaderTest extends TestCase {
- // ======================================================
- // the test cases
- // ======================================================
-
- public void testConstructors() {
- ExtendedBufferedReader br = new ExtendedBufferedReader(new StringReader(""));
- br = new ExtendedBufferedReader(new StringReader(""), 10);
- }
-
public void testReadLookahead1() throws Exception {
assertEquals(ExtendedBufferedReader.END_OF_STREAM, getEBR("").read());