[GitHub] [fluo-muchos] keith-turner commented on a change in pull request #328: Added support for Red Hat OS

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #328: Added support for Red Hat OS
URL: https://github.com/apache/fluo-muchos/pull/328#discussion_r389185746
 
 

 ##########
 File path: ansible/scripts/install_ansible.sh
 ##########
 @@ -22,9 +22,19 @@ base_dir=$( cd "$( dirname "$bin" )" && pwd )
 
 set -e
 
+# get the release id
+if [ -f /etc/os-release ]; then
+  . /etc/os-release
+  ID=$ID
+fi
+
 # enable yum epel repo
-is_installed_epel_release="rpm -q --quiet epel-release"
-install_epel_release="sudo yum install -q -y epel-release"
+if [ $ID = "rhel" ]; then
+  is_installed_epel_release="rpm -q --quiet epel-release"
+else
+  install_epel_release="sudo yum install -q -y epel-release"
 
 Review comment:
   Seems like `install_epel_release` will always be overridden immediately after the if/else. If so, why set it here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services