You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by David Leangen <os...@leangen.net> on 2006/09/22 04:42:23 UTC
Patch for VersionRange
Don't know the best way to submit this, but here is a small patch to
show "prettier" error and warning messages than currently.
Index:
src/main/java/org/apache/felix/framework/searchpolicy/VersionRange.java
===================================================================
---
src/main/java/org/apache/felix/framework/searchpolicy/VersionRange.java
(revision 448749)
+++
src/main/java/org/apache/felix/framework/searchpolicy/VersionRange.java
(working copy)
@@ -95,4 +95,11 @@
return new VersionRange(new Version(range), true, null,
false);
}
}
-}
\ No newline at end of file
+
+ public String toString()
+ {
+ final char lowerBound = m_isLowInclusive ? '(' : '[' ;
+ final char upperBound = m_isHighInclusive ? ')' : ']' ;
+ return "" + lowerBound + m_low + ',' + m_high + upperBound;
+ }
+}
Re: Patch for VersionRange
Posted by "Richard S. Hall" <he...@ungoverned.org>.
Ok, I added a modified patch to pretty print version ranges...thanks.
-> richard
David Leangen wrote:
> Don't know the best way to submit this, but here is a small patch to
> show "prettier" error and warning messages than currently.
>
>
>
> Index:
> src/main/java/org/apache/felix/framework/searchpolicy/VersionRange.java
> ===================================================================
> ---
> src/main/java/org/apache/felix/framework/searchpolicy/VersionRange.java
> (revision 448749)
> +++
> src/main/java/org/apache/felix/framework/searchpolicy/VersionRange.java
> (working copy)
> @@ -95,4 +95,11 @@
> return new VersionRange(new Version(range), true, null,
> false);
> }
> }
> -}
> \ No newline at end of file
> +
> + public String toString()
> + {
> + final char lowerBound = m_isLowInclusive ? '(' : '[' ;
> + final char upperBound = m_isHighInclusive ? ')' : ']' ;
> + return "" + lowerBound + m_low + ',' + m_high + upperBound;
> + }
> +}
>
>
>
Re: Patch for VersionRange
Posted by "Richard S. Hall" <he...@ungoverned.org>.
David Leangen wrote:
> +
> + public String toString()
> + {
> + final char lowerBound = m_isLowInclusive ? '(' : '[' ;
> + final char upperBound = m_isHighInclusive ? ')' : ']' ;
> + return "" + lowerBound + m_low + ',' + m_high + upperBound;
> + }
> +}
After looking at this patch more closely, I believe the brackets and
parentheses are reversed.
-> richard