[jira] [Commented] (ACCUMULO-987) Check for and schedule for removal (deprecate) any thrift objects in public API

["Keith Turner (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACCUMULO-987?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13608439#comment-13608439 ] 

Keith Turner commented on ACCUMULO-987:
---------------------------------------

I looked into this.  I searched for java files in the public API that contained "import*thrift*" then examined those files.  I found the following.

{code:java}
MutationsRejectedException 
  public Map<KeyExtent,Set<SecurityErrorCode>> getAuthorizationFailuresMap()   //New in 1.5, SecurityErrorCode is thrift enum

AccumuloSecurityException
  public SecurityErrorCode getErrorCode()  //exist in 1.4

//For the following two, the javadoc refs a method that takes a thrift object

mapred.InputFormatBase
   /**
   * {@link CredentialHelper#asBase64String(TCredentials)}.
   */
   public static void setConnectorInfo(JobConf job, Path path)

mapreduce.InputFormatBase
   /**
   * {@link CredentialHelper#asBase64String(TCredentials)}.
   */
  public static void setConnectorInfo(Job job, Path path) {
{code}

                
> Check for and schedule for removal (deprecate) any thrift objects in public API
> -------------------------------------------------------------------------------
>
>                 Key: ACCUMULO-987
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-987
>             Project: Accumulo
>          Issue Type: Sub-task
>            Reporter: Christopher Tubbs
>            Assignee: Christopher Tubbs
>             Fix For: 1.5.0
>
>
> Thrift objects should not be exposed as part of the public API. This is a quick check to ensure we deprecate any that happened to have made it in there, before we release 1.5, so that we can have an opportunity to remove them in 1.6.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira