You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/07 13:00:38 UTC
[GitHub] [arrow] mqy opened a new pull request #9124: ARROW-11131: [Rust] Improve performance of boolean_equal
mqy opened a new pull request #9124:
URL: https://github.com/apache/arrow/pull/9124
This PR optimized performance of `boolean_equal` and added benches for this.
The average change is about -95% for both `equal_bool_512` and `equal_bool_513`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9124: ARROW-11131: [Rust] Improve performance of boolean_equal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9124:
URL: https://github.com/apache/arrow/pull/9124#issuecomment-756102300
https://issues.apache.org/jira/browse/ARROW-11131
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao closed pull request #9124: ARROW-11131: [Rust] Improve performance of boolean_equal
Posted by GitBox <gi...@apache.org>.
jorgecarleitao closed pull request #9124:
URL: https://github.com/apache/arrow/pull/9124
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9124: ARROW-11131: [Rust] Improve performance of boolean_equal
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9124:
URL: https://github.com/apache/arrow/pull/9124#issuecomment-756127294
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9124?src=pr&el=h1) Report
> Merging [#9124](https://codecov.io/gh/apache/arrow/pull/9124?src=pr&el=desc) (678baf0) into [master](https://codecov.io/gh/apache/arrow/commit/98159f18dae0fdccfa967bfc452966a054e41cce?el=desc) (98159f1) will **increase** coverage by `0.00%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/arrow/pull/9124?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9124 +/- ##
=======================================
Coverage 82.60% 82.61%
=======================================
Files 204 204
Lines 50496 50517 +21
=======================================
+ Hits 41713 41733 +20
- Misses 8783 8784 +1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9124?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow/src/array/equal/boolean.rs](https://codecov.io/gh/apache/arrow/pull/9124/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvZXF1YWwvYm9vbGVhbi5ycw==) | `100.00% <100.00%> (ø)` | |
| [rust/arrow/src/array/equal/mod.rs](https://codecov.io/gh/apache/arrow/pull/9124/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvZXF1YWwvbW9kLnJz) | `92.92% <100.00%> (+0.10%)` | :arrow_up: |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9124/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.24% <0.00%> (-0.20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9124?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9124?src=pr&el=footer). Last update [98159f1...fa6382b](https://codecov.io/gh/apache/arrow/pull/9124?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mqy commented on pull request #9124: ARROW-11131: [Rust] [Arrow] Improve performance of boolean_equal
Posted by GitBox <gi...@apache.org>.
mqy commented on pull request #9124:
URL: https://github.com/apache/arrow/pull/9124#issuecomment-756549714
@nevi-me would you please review this PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorgecarleitao closed pull request #9124: ARROW-11131: [Rust] Improve performance of boolean_equal
Posted by GitBox <gi...@apache.org>.
jorgecarleitao closed pull request #9124:
URL: https://github.com/apache/arrow/pull/9124
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org