You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2021/04/14 15:42:41 UTC
[GitHub] [ignite] vldpyatkov commented on a change in pull request #8955: IGNITE-14331 Fixed DataStreamer.flush()
vldpyatkov commented on a change in pull request #8955:
URL: https://github.com/apache/ignite/pull/8955#discussion_r613363614
##########
File path: modules/core/src/main/java/org/apache/ignite/internal/processors/datastreamer/DataStreamerImpl.java
##########
@@ -1999,26 +1999,29 @@ private void submit(
if (log.isDebugEnabled())
log.debug("Sent request to node [nodeId=" + node.id() + ", req=" + req + ']');
}
- catch (ClusterTopologyCheckedException e) {
- GridFutureAdapter<Object> fut0 = ((GridFutureAdapter<Object>)fut);
-
- fut0.onDone(e);
- }
catch (IgniteCheckedException e) {
+ // This request was not sent probably.
+ // Anyway it does not make sense to track it.
+ reqs.remove(reqId);
+
GridFutureAdapter<Object> fut0 = ((GridFutureAdapter<Object>)fut);
- if (X.hasCause(e, IgniteClientDisconnectedCheckedException.class, IgniteClientDisconnectedException.class))
+ if (e instanceof ClusterTopologyCheckedException)
fut0.onDone(e);
else {
- try {
- if (ctx.discovery().alive(node) && ctx.discovery().pingNode(node.id()))
- fut0.onDone(e);
- else
- fut0.onDone(new ClusterTopologyCheckedException("Failed to send request (node has left): "
- + node.id()));
- }
- catch (IgniteClientDisconnectedCheckedException e0) {
- fut0.onDone(e0);
+ if (X.hasCause(e, IgniteClientDisconnectedCheckedException.class, IgniteClientDisconnectedException.class))
Review comment:
If I was in your place I merge this condition and above to one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org