[GitHub] [doris] yiguolei commented on a diff in pull request #18051: [feature](agg) Support spill to disk in aggregation

["yiguolei (via GitHub)" <gi...@apache.org>]

yiguolei commented on code in PR #18051:
URL: https://github.com/apache/doris/pull/18051#discussion_r1156662275


##########
be/src/vec/data_types/data_type_fixed_length_object.h:
##########
@@ -61,6 +61,7 @@ class DataTypeFixedLengthObject final : public IDataType {
 
     bool is_categorial() const override { return is_value_represented_by_integer(); }
     bool can_be_inside_low_cardinality() const override { return false; }
+    bool can_be_inside_nullable() const override { return true; }

Review Comment:
   This method is useless?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org