[GitHub] [hadoop] tomicooler commented on a change in pull request #3755: YARN-11033. isAbsoluteResource is not correct for dynamically created queues.

[GitBox <gi...@apache.org>]

tomicooler commented on a change in pull request #3755:
URL: https://github.com/apache/hadoop/pull/3755#discussion_r764032788



##########
File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/webapp/dao/CapacitySchedulerInfo.java
##########
@@ -88,6 +90,9 @@ public CapacitySchedulerInfo(CSQueue parent, CapacityScheduler cs) {
     health = new CapacitySchedulerHealthInfo(cs);
     maximumAllocation = new ResourceInfo(parent.getMaximumAllocation());
 
+    isAbsoluteResource = parent.getCapacityConfigType() ==
+        AbstractCSQueue.CapacityConfigType.ABSOLUTE_RESOURCE;
+

Review comment:
       I think the mode property is superior to the isAbsoluteResource flag, the latter was introduced before the mode property AFAIk. I just added to the root level for consistency, if someone wants to build something on the isAbsoluteResource property. The mode property is available on root level too.
   
   So it's just for consistency. But if not needed I can remove this change, that's why I added to a separate commit.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org