You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/03/15 06:27:48 UTC

[GitHub] [bookkeeper] codelipenghui commented on a change in pull request #3110: Fix ledgerEntryImpl reuse problem

codelipenghui commented on a change in pull request #3110:
URL: https://github.com/apache/bookkeeper/pull/3110#discussion_r826617880



##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
##########
@@ -563,6 +565,10 @@ public long getLastAddConfirmed() {
         }
     }
 
+    public static ReadContext createReadContext(int bookieIndex, BookieId to, LedgerEntryRequest entry) {

Review comment:
       Don't need to be a public method? Looks only used for tests.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org